Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: remoting/client/chromoting_client.cc

Issue 10843031: Piping for audio decoding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed an #include to a forward declaration Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/chromoting_client.cc
diff --git a/remoting/client/chromoting_client.cc b/remoting/client/chromoting_client.cc
index f0dd8c79c477c216e6c5c9b1e14c1d0d599c70bc..a41fe3b09bb053b60eb47d996062e81946cc3dcd 100644
--- a/remoting/client/chromoting_client.cc
+++ b/remoting/client/chromoting_client.cc
@@ -5,6 +5,7 @@
#include "remoting/client/chromoting_client.h"
#include "base/bind.h"
+#include "remoting/client/audio_decode_scheduler.h"
#include "remoting/client/audio_player.h"
#include "remoting/client/client_context.h"
#include "remoting/client/client_user_interface.h"
@@ -31,20 +32,23 @@ ChromotingClient::QueuedVideoPacket::~QueuedVideoPacket() {
ChromotingClient::ChromotingClient(
const ClientConfig& config,
- scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ const ClientContext& client_context,
protocol::ConnectionToHost* connection,
ClientUserInterface* user_interface,
RectangleUpdateDecoder* rectangle_decoder,
- AudioPlayer* audio_player)
+ scoped_ptr<AudioPlayer> audio_player)
: config_(config),
- task_runner_(task_runner),
+ task_runner_(client_context.main_task_runner()),
connection_(connection),
user_interface_(user_interface),
rectangle_decoder_(rectangle_decoder),
- audio_player_(audio_player),
packet_being_processed_(false),
last_sequence_number_(0),
weak_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
+ audio_decode_scheduler_.reset(new AudioDecodeScheduler(
+ client_context.main_task_runner(),
+ client_context.audio_decode_task_runner(),
+ audio_player.Pass()));
}
ChromotingClient::~ChromotingClient() {
@@ -65,7 +69,8 @@ void ChromotingClient::Start(
connection_->Connect(xmpp_proxy, config_.local_jid, config_.host_jid,
config_.host_public_key, transport_factory.Pass(),
- authenticator.Pass(), this, this, this, this, this);
+ authenticator.Pass(), this, this, this, this,
+ audio_decode_scheduler_.get());
}
void ChromotingClient::Stop(const base::Closure& shutdown_task) {
@@ -141,12 +146,6 @@ int ChromotingClient::GetPendingVideoPackets() {
return received_packets_.size();
}
-void ChromotingClient::ProcessAudioPacket(scoped_ptr<AudioPacket> packet,
- const base::Closure& done) {
- audio_player_->ProcessAudioPacket(packet.Pass());
- done.Run();
-}
-
void ChromotingClient::DispatchPacket() {
DCHECK(task_runner_->BelongsToCurrentThread());
CHECK(!packet_being_processed_);
@@ -217,6 +216,9 @@ void ChromotingClient::Initialize() {
// Initialize the decoder.
rectangle_decoder_->Initialize(connection_->config());
+ if (connection_->config().is_audio_enabled()) {
Sergey Ulanov 2012/08/03 17:59:55 remove brackets for consistency with other one-lin
kxing 2012/08/03 20:55:13 Done.
+ audio_decode_scheduler_->Initialize(connection_->config());
+ }
}
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698