Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1084303002: Replace FX_NEW with new, remote tests from fxcodec (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M core/src/fxcodec/codec/fx_codec.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 3 chunks +3 lines, -12 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 3 chunks +3 lines, -13 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, thanks.
5 years, 8 months ago (2015-04-15 22:36:34 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-16 18:37:24 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-16 21:21:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfc1a654ef3e8b65bc447815d35932c185bf1422 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698