[PresentationAPI] Added on-session-message handler.

[PresentationAPI] Added on-session-message handler.

Depends on the Blink change: https://codereview.chromium.org/1092193003/

BUG=459008
Committed: https://crrev.com/ab7d597bb5512d37f39393196ac5ce0c19bec23e
Cr-Commit-Position: refs/heads/master@{#327531}

[haibinlu, 2015-04-22 00:09:17]

haibinlu@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2015-04-23 16:52:27]

lgtm % nits

https://codereview.chromium.org/1084293004/diff/1/content/common/presentation...
File content/common/presentation/presentation_service.mojom (right):

https://codereview.chromium.org/1084293004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:88:
ListenForSessionTextMessage()
The Mojo document has something like this:

ListenForSessionTextMessage(PresentationSessionInfo sessionInfo) =>
(array[string] messages);

Using the array would handle the throttling problem (if the page is slow
receiving messages, we can send a batch of accumulated messages from the
browser/MR).
sessionInfo would probably be useful if we would only want to send messages to
the session that have onmessage event handlers set. However, I think we'd send
the messages to all the sessions so your version of passing the sessionInfo in
the callback is better.

So something like this then?

ListenForSessionTextMessage() => (PresentationSessionInfo sessionInfo,
array[string] messages);

https://codereview.chromium.org/1084293004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:89: =>
(PresentationSessionInfo sessionInfo, string message);
Also consider making it a MessageRequest that would wrap string, arrays and
blobs? Could be left until the time we add support for those though.
Still with that in mind probably can omit Text from the method names.

[haibinlu, 2015-04-25 00:03:23]

haibinlu@chromium.org changed reviewers:
+ imcheng@chromium.org

[haibinlu, 2015-04-25 00:05:14]

PTAL

https://codereview.chromium.org/1084293004/diff/1/content/common/presentation...
File content/common/presentation/presentation_service.mojom (right):

https://codereview.chromium.org/1084293004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:88:
ListenForSessionTextMessage()
On 2015/04/23 16:52:27, whywhat wrote:
> The Mojo document has something like this:
> 
> ListenForSessionTextMessage(PresentationSessionInfo sessionInfo) =>
> (array[string] messages);
> 
> Using the array would handle the throttling problem (if the page is slow
> receiving messages, we can send a batch of accumulated messages from the
> browser/MR).
> sessionInfo would probably be useful if we would only want to send messages to
> the session that have onmessage event handlers set. However, I think we'd send
> the messages to all the sessions so your version of passing the sessionInfo in
> the callback is better.
> 
> So something like this then?
> 
> ListenForSessionTextMessage() => (PresentationSessionInfo sessionInfo,
> array[string] messages);

Done. the callback parameter is array<SessionMessage>

https://codereview.chromium.org/1084293004/diff/1/content/common/presentation...
content/common/presentation/presentation_service.mojom:89: =>
(PresentationSessionInfo sessionInfo, string message);
On 2015/04/23 16:52:27, whywhat wrote:
> Also consider making it a MessageRequest that would wrap string, arrays and
> blobs? Could be left until the time we add support for those though.
> Still with that in mind probably can omit Text from the method names.

Added SessionMessage, borrowed from send-message CL. Will merge

[whywhat, 2015-04-25 19:04:23]

lgtm

[haibinlu, 2015-04-28 22:54:16]

The CQ bit was checked by haibinlu@chromium.org

[haibinlu, 2015-04-28 22:54:17]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1084293004/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2015-04-28 22:55:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084293004/40001

[commit-bot: I haz the power, 2015-04-28 23:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 23:07:24]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haibinlu, 2015-04-29 17:32:59]

The CQ bit was checked by haibinlu@chromium.org

[haibinlu, 2015-04-29 17:33:00]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1084293004/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2015-04-29 17:33:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084293004/60001

[commit-bot: I haz the power, 2015-04-29 18:49:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-29 18:50:34]

Patchset 4 (id:??) landed as
https://crrev.com/ab7d597bb5512d37f39393196ac5ce0c19bec23e
Cr-Commit-Position: refs/heads/master@{#327531}