[turbofan] Sanitize language mode for javascript operators.

[turbofan] Sanitize language mode for javascript operators.

R=mstarzinger@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/f13f949361eb8531a15f1ba80a3f42044d16a52c

[Benedikt Meurer, 2015-04-27 08:53:02]

Hey Michi,

As discussed offline: Make this whole language mode thing more robust and less
error prone. Plus fix up the tests.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-04-27 09:04:22]

LGTM. Thank you!

[Benedikt Meurer, 2015-04-27 09:04:41]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-04-27 09:04:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084243005/1

[Benedikt Meurer, 2015-04-27 09:12:44]

The CQ bit was unchecked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-04-27 09:13:23]

Patchset 1 (id:??) landed as
https://crrev.com/f13f949361eb8531a15f1ba80a3f42044d16a52c
Cr-Commit-Position: refs/heads/master@{#28059}

[Benedikt Meurer, 2015-04-27 09:13:24]

Committed patchset #1 (id:1) manually as
f13f949361eb8531a15f1ba80a3f42044d16a52c (presubmit successful).

[conradw, 2015-04-27 10:23:52]

conradw@chromium.org changed reviewers:
+ conradw@chromium.org

[conradw, 2015-04-27 10:23:53]

https://codereview.chromium.org/1084243005/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1084243005/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:281: Name##Operator<STRICT> k##Name##StrictOperator;
                            \
This change means that operators which behave identically in sloppy and strict
mode have separate cached versions for the two modes. This seems odd, especially
since Store only caches sloppy and strict versions. Also, as it stands
currently, none of the strict cached operators here are ever used by any code.

[Benedikt Meurer, 2015-04-27 10:33:04]

On 2015/04/27 10:23:53, conradw wrote:
> https://codereview.chromium.org/1084243005/diff/1/src/compiler/js-operator.cc
> File src/compiler/js-operator.cc (right):
> 
>
https://codereview.chromium.org/1084243005/diff/1/src/compiler/js-operator.cc...
> src/compiler/js-operator.cc:281: Name##Operator<STRICT>
k##Name##StrictOperator;
>                             \
> This change means that operators which behave identically in sloppy and strict
> mode have separate cached versions for the two modes. This seems odd,
especially
> since Store only caches sloppy and strict versions. Also, as it stands
> currently, none of the strict cached operators here are ever used by any code.

Yes. That's actually intentional. Otherwise you'll get odd behavior, i.e.

  OpParameter<LanguageMode>(javascript()->Operator(STRICT)) != STRICT

which I'm sure will cause trouble at some point, and is completely weird.