Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1084243003: Update NET_INFO_SOURCE macros. (Closed)

Created:
5 years, 8 months ago by Bence
Modified:
5 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update NET_INFO_SOURCE macros. s/ALT_PROTO/ALT_SVC/ in NET_INFO_SOURCE macros. Follow-up to https://crrev.com/1075383003/diff/40001/net/log/net_log_util.cc#newcode481. BUG=476068 Committed: https://crrev.com/940453d0ab81b85bf68c3de715fde1a9f538b159 Cr-Commit-Position: refs/heads/master@{#325689}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re: #3. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M net/base/net_info_source_list.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M net/log/net_log_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 8 months ago (2015-04-16 20:55:00 UTC) #2
Ryan Hamilton
s/HTTP2/SPDY/ then LGTM. https://codereview.chromium.org/1084243003/diff/1/net/base/net_info_source_list.h File net/base/net_info_source_list.h (right): https://codereview.chromium.org/1084243003/diff/1/net/base/net_info_source_list.h#newcode18 net/base/net_info_source_list.h:18: NET_INFO_SOURCE(HTTP2_SESSIONS, "spdySessionInfo", 1 << 5) Let's ...
5 years, 8 months ago (2015-04-17 17:12:27 UTC) #3
Bence
Thanks. https://codereview.chromium.org/1084243003/diff/1/net/base/net_info_source_list.h File net/base/net_info_source_list.h (right): https://codereview.chromium.org/1084243003/diff/1/net/base/net_info_source_list.h#newcode18 net/base/net_info_source_list.h:18: NET_INFO_SOURCE(HTTP2_SESSIONS, "spdySessionInfo", 1 << 5) On 2015/04/17 17:12:27, ...
5 years, 8 months ago (2015-04-17 17:46:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084243003/20001
5 years, 8 months ago (2015-04-17 17:49:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 18:54:04 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 18:54:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/940453d0ab81b85bf68c3de715fde1a9f538b159
Cr-Commit-Position: refs/heads/master@{#325689}

Powered by Google App Engine
This is Rietveld 408576698