[sql] New SQLite values for SqliteErrorCode enum.

[sql] New SQLite values for SqliteErrorCode enum.

New error codes from 3.8.7.4 import.

BUG=340757
Committed: https://crrev.com/814e0192b9adbc5abc9b913d37cf0dfc18b9e5f6
Cr-Commit-Position: refs/heads/master@{#325288}

[Scott Hess - ex-Googler, 2015-04-15 17:55:32]

shess@chromium.org changed reviewers:
+ mpearson@chromium.org

[Scott Hess - ex-Googler, 2015-04-15 17:55:32]

The ordering is odd because SQLite extended error codes look like (base_error +
(N<<8)), where N is 1, 2, 3, etc.  So:
  SQLITE_IOERR 10
  SQLITE_IOERR_READ 266
  SQLITE_IOERR_SHORT_READ 522
etc.  They did this so that you could mask your way back to the base_error.

[Scott Hess - ex-Googler, 2015-04-15 17:56:35]

https://codereview.chromium.org/1084243002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1084243002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61134: +  <int value="264"
label="SQLITE_READONLY_RECOVERY">TBD</int>
I filled in all of the symbolic values, but only researched the meaning for
cases where I'm already seeing results on the UMA dashboards.

[Mark P, 2015-04-15 18:04:45]

lgtm

https://codereview.chromium.org/1084243002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1084243002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61134: +  <int value="264"
label="SQLITE_READONLY_RECOVERY">TBD</int>
On 2015/04/15 17:56:35, Scott Hess wrote:
> I filled in all of the symbolic values, but only researched the meaning for
> cases where I'm already seeing results on the UMA dashboards.

Acknowledged.  Did you check all the histograms that emit SQL error codes?

[Scott Hess - ex-Googler, 2015-04-15 18:10:49]

thanks.

https://codereview.chromium.org/1084243002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1084243002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61134: +  <int value="264"
label="SQLITE_READONLY_RECOVERY">TBD</int>
On 2015/04/15 18:04:45, Mark P wrote:
> On 2015/04/15 17:56:35, Scott Hess wrote:
> > I filled in all of the symbolic values, but only researched the meaning for
> > cases where I'm already seeing results on the UMA dashboards.
> 
> Acknowledged.  Did you check all the histograms that emit SQL error codes?

AFAICT I hit all of them using this enum, though I believe Sqlite.Error (w/o
suffix) should contain the union of everything.

[Scott Hess - ex-Googler, 2015-04-15 18:10:53]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2015-04-15 18:11:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084243002/1

[commit-bot: I haz the power, 2015-04-15 19:38:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-15 19:39:27]

Patchset 1 (id:??) landed as
https://crrev.com/814e0192b9adbc5abc9b913d37cf0dfc18b9e5f6
Cr-Commit-Position: refs/heads/master@{#325288}