Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 1084183004: Revert of [es6] implement Array.prototype.copyWithin() (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/376623004/) Reason for revert: [Sheriff] This causes test failures on mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 Original issue's description: > [es6] implement Array.prototype.copyWithin() > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > BUG=v8:4039 > R=adamk@chromium.org > LOG=N TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Committed: https://crrev.com/9283fc89710e59445bdc4479454fba97ab9ebdd7 Cr-Commit-Position: refs/heads/master@{#27984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -393 lines) Patch
M src/harmony-array.js View 3 chunks +0 lines, -55 lines 0 comments Download
D test/mjsunit/harmony/array-copywithin.js View 1 chunk +0 lines, -338 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
Created Revert of [es6] implement Array.prototype.copyWithin()
5 years, 8 months ago (2015-04-21 21:11:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084183004/1
5 years, 8 months ago (2015-04-21 21:11:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 21:11:50 UTC) #3
caitp (gmail)
On 2015/04/21 21:11:50, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) Lgtm, ...
5 years, 8 months ago (2015-04-21 21:29:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9283fc89710e59445bdc4479454fba97ab9ebdd7 Cr-Commit-Position: refs/heads/master@{#27984}
5 years, 8 months ago (2015-04-22 04:10:49 UTC) #5
Michael Achenbach
5 years, 8 months ago (2015-04-22 09:43:14 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1072193005/ by machenbach@chromium.org.

The reason for reverting is: Check if this CL fails independently of
https://chromium.googlesource.com/v8/v8/+/580d66bcda66220d2f3062ac58daf925436....

Powered by Google App Engine
This is Rietveld 408576698