Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: ui/ozone/platform/drm/gpu/page_flip_request.cc

Issue 1084173004: Adding status to swap complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/page_flip_request.cc
diff --git a/ui/ozone/platform/drm/gpu/page_flip_request.cc b/ui/ozone/platform/drm/gpu/page_flip_request.cc
index dfca208874abcfd17c8d9941362c1b202328aa7d..3c9bf3a2a1f5844002d985c541735d80733f19af 100644
--- a/ui/ozone/platform/drm/gpu/page_flip_request.cc
+++ b/ui/ozone/platform/drm/gpu/page_flip_request.cc
@@ -4,19 +4,27 @@
#include "ui/ozone/platform/drm/gpu/page_flip_request.h"
-#include "base/barrier_closure.h"
-
namespace ui {
-PageFlipRequest::PageFlipRequest(int crtc_count, const base::Closure& callback)
- : callback_(base::BarrierClosure(crtc_count, callback)) {
+PageFlipRequest::PageFlipRequest(
+ int crtc_count,
+ const base::Callback<void(gfx::SwapResult)>& callback)
alexst (slow to review) 2015/05/08 15:00:46 SwapCompletionCallback
achaulk 2015/05/14 18:15:46 Done.
+ : callback_(callback), refcount_(crtc_count), result_(gfx::SwapAck) {
alexst (slow to review) 2015/05/08 15:00:46 crtc_count_ for consistency.
achaulk 2015/05/14 18:15:46 Done.
}
PageFlipRequest::~PageFlipRequest() {
}
-void PageFlipRequest::Signal() {
- callback_.Run();
+void PageFlipRequest::Signal(gfx::SwapResult result) {
+ if (result == gfx::SwapFailed)
+ result_ = gfx::SwapFailed;
+ else if (result != gfx::SwapAck)
+ result_ = result;
+
+ if (!--refcount_) {
+ callback_.Run(result_);
+ callback_.Reset();
+ }
}
} // namespace ui

Powered by Google App Engine
This is Rietveld 408576698