Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: ui/ozone/platform/drm/gpu/page_flip_request.h

Issue 1084173004: Adding status to swap complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, separate out use of the result, add enum Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/page_flip_request.h
diff --git a/ui/ozone/platform/drm/gpu/page_flip_request.h b/ui/ozone/platform/drm/gpu/page_flip_request.h
index c1a63b25389d6847a3ae0287f44b54fd2c61332e..c418a446817e20237eb3106d8f8433471c47128a 100644
--- a/ui/ozone/platform/drm/gpu/page_flip_request.h
+++ b/ui/ozone/platform/drm/gpu/page_flip_request.h
@@ -5,22 +5,27 @@
#ifndef UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_
#define UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_
+#include "base/atomic_ref_count.h"
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
+#include "ui/gfx/swap_result.h"
namespace ui {
class PageFlipRequest : public base::RefCounted<PageFlipRequest> {
public:
- PageFlipRequest(int crtc_count, const base::Closure& callback);
+ PageFlipRequest(int crtc_count,
+ const base::Callback<void(gfx::SwapResult)>& callback);
alexst (slow to review) 2015/04/29 17:53:37 Let's typedef too.
achaulk 2015/05/06 18:29:48 Done.
- void Signal();
+ void Signal(gfx::SwapResult result);
private:
friend class base::RefCounted<PageFlipRequest>;
~PageFlipRequest();
- base::Closure callback_;
+ base::Callback<void(gfx::SwapResult)> callback_;
+ base::AtomicRefCount count_;
alexst (slow to review) 2015/04/29 17:53:37 These all come on the same thread, so no need to u
achaulk 2015/05/06 18:29:48 I just duplicated the implementation which used at
+ gfx::SwapResult result_;
DISALLOW_COPY_AND_ASSIGN(PageFlipRequest);
};

Powered by Google App Engine
This is Rietveld 408576698