Adding status to swap complete

ui/ozone/platform/drm/gpu/page_flip_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_
 #define UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_
 
+#include "base/atomic_ref_count.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
+#include "ui/gfx/swap_result.h"
+#include "ui/ozone/public/surface_ozone_egl.h"
 
 namespace ui {
 
 class PageFlipRequest : public base::RefCounted<PageFlipRequest> {
  public:
-  PageFlipRequest(int crtc_count, const base::Closure& callback);
+  typedef SurfaceOzoneEGL::SwapCompletionCallback SwapCompletionCallback;

[dnicoara, 2015/05/08 15:15:41]

nit: Would it make sense to typedef this outside a class scope and just re-use
it everywhere in the drm platform?

[achaulk, 2015/05/14 18:15:46]

Sure, though it's either adding a typedef here or an include at the top

[dnicoara, 2015/05/14 18:44:54]

I was hoping to have the typedef done in one place and just reuse it everywhere
else. You've typedef-ed it in 3-4 places and they are all the same. I just
thought it would make it easier to follow if one doesn't need to go back and
forth making sure it is the same typedef everywhere.

[achaulk, 2015/05/14 18:53:05]

One for the entire build or for ozone?

[dnicoara, 2015/05/14 18:58:59]

Whichever is more reasonable. I think this is only used in Ozone at the moment,
so you could just typedef the callback outside SurfaceOzoneEGL. Then you
wouldn't need all the convenience typedefs sprinkled everywhere.

[achaulk, 2015/05/14 20:38:26]

Done.

+  PageFlipRequest(int crtc_count, const SwapCompletionCallback& callback);
 
-  void Signal();
+  void Signal(gfx::SwapResult result);
 
  private:
   friend class base::RefCounted<PageFlipRequest>;
   ~PageFlipRequest();
 
-  base::Closure callback_;
+  SwapCompletionCallback callback_;
+  int refcount_;
+  gfx::SwapResult result_;
 
   DISALLOW_COPY_AND_ASSIGN(PageFlipRequest);
 };
 
 }  // namespace ui
 
 #endif  // UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_