Adding status to swap complete

ui/gl/gl_surface.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/threading/thread_local.h"
 #include "base/trace_event/trace_event.h"
+#include "ui/gfx/swap_result.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_switches.h"
 
 #if defined(USE_X11)
 #include <X11/Xlib.h>
 #endif
 
 namespace gfx {
 
@@ skipping 163 matching lines @@
   return false;
 }
 
 unsigned int GLSurface::GetBackingFrameBufferObject() {
   return 0;
 }
 
 bool GLSurface::SwapBuffersAsync(const SwapCompletionCallback& callback) {
   DCHECK(!IsSurfaceless());
   bool success = SwapBuffers();
-  callback.Run();
+  callback.Run(SwapAck);

[piman, 2015/05/13 16:53:16]

SwapAck seems wrong if !success. Should SwapBuffers return a SwapAck instead?

[achaulk, 2015/05/14 18:15:46]

Ah, yeah I just changed it to switch off of the bool

[piman, 2015/05/14 19:08:19]

Can you change the return value of SwapBuffers instead? Is there a fundamental
reason why the sync and async versions should differ?

[achaulk, 2015/05/14 20:38:26]

Done.

   return success;
 }
 
 bool GLSurface::PostSubBuffer(int x, int y, int width, int height) {
   return false;
 }
 
 bool GLSurface::PostSubBufferAsync(int x,
                                    int y,
                                    int width,
                                    int height,
                                    const SwapCompletionCallback& callback) {
   bool success = PostSubBuffer(x, y, width, height);
-  callback.Run();
+  callback.Run(SwapAck);
   return success;
 }
 
 bool GLSurface::OnMakeCurrent(GLContext* context) {
   return true;
 }
 
 void GLSurface::NotifyWasBound() {
 }
 
@@ skipping 172 matching lines @@
       z_order, transform, image, bounds_rect, crop_rect);
 }
 
 bool GLSurfaceAdapter::IsSurfaceless() const {
   return surface_->IsSurfaceless();
 }
 
 GLSurfaceAdapter::~GLSurfaceAdapter() {}
 
 }  // namespace gfx