ui/gfx/swap_result.h - Issue 1084173004: Adding status to swap complete

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/swap_result.h

Issue 1084173004: Adding status to swap complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/gfx/screen.h"	5 #ifndef UI_GFX_SWAP_RESULT_H_

6	6 #define UI_GFX_SWAP_RESULT_H_

7 #include "base/logging.h"

8	7

9 namespace gfx {	8 namespace gfx {

10	9

11 Screen* CreateNativeScreen() {	10 enum SwapResult {

12 NOTREACHED() << "Implementation should be installed at higher level.";	11 SwapAck,
	dnicoara 2015/05/08 15:15:41 style guide says you should be using MACRO_STYLE f style guide says you should be using MACRO_STYLE for enum values. achaulk 2015/05/14 18:15:46 Done. Show quoted text On 2015/05/08 15:15:41, dnicoara wrote: > style guide says you should be using MACRO_STYLE for enum values. Done.
13 return NULL;	12 SwapFailed,

14 }	13 SwapNakRecreateBuffers,

	14 SWAP_RESULT_LAST,

	15 };

15	16

16 } // namespace gfx	17 } // namespace gfx

	18

	19 #endif // UI_GFX_SWAP_RESULT_H_

OLD	NEW