ui/gfx/swap_result.h - Issue 1084173004: Adding status to swap complete

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/swap_result.h

Issue 1084173004: Adding status to swap complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set SWAP_RESULT_LAST properly Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	nasko 2015/05/26 18:20:16 Update the year and drop the "(c)". Update the year and drop the "(c)". achaulk 2015/05/26 21:09:36 Done. Show quoted text On 2015/05/26 18:20:16, nasko wrote: > Update the year and drop the "(c)". Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_SWAP_RESULT_H_

	6 #define UI_GFX_SWAP_RESULT_H_

	7

	8 namespace gfx {

	9

	10 enum class SwapResult {
	nasko 2015/05/26 18:20:16 Is there another gfx header file for this to be in Is there another gfx header file for this to be included in? Since it is about swapping buffers, wouldn't ui/gfx/gpu_memory_buffer.h work? achaulk 2015/05/26 21:09:36 I'm not sure there's an appropriate one really. Gp Show quoted text On 2015/05/26 18:20:16, nasko wrote: > Is there another gfx header file for this to be included in? Since it is about > swapping buffers, wouldn't ui/gfx/gpu_memory_buffer.h work? I'm not sure there's an appropriate one really. Gpu memory buffer is a loose fit at best, as it doesn't have any relation to the SwapBuffers path. But I'll move it if you want, it's no big deal nasko 2015/05/26 21:18:47 If it is unrelated, that's fine. I just want to av Show quoted text On 2015/05/26 21:09:36, achaulk wrote: > On 2015/05/26 18:20:16, nasko wrote: > > Is there another gfx header file for this to be included in? Since it is about > > swapping buffers, wouldn't ui/gfx/gpu_memory_buffer.h work? > > I'm not sure there's an appropriate one really. Gpu memory buffer is a loose fit > at best, as it doesn't have any relation to the SwapBuffers path. But I'll move > it if you want, it's no big deal If it is unrelated, that's fine. I just want to avoid adding a new file for the sake of one enum. Usually, we have an _enums.h version of the file that contains the enums used in _messages.h file, so I wanted to see if there is such a thing for gfx. You still need to add this file to the appropriate .gypi file. achaulk 2015/05/27 17:57:09 Added Show quoted text On 2015/05/26 21:18:47, nasko wrote: > On 2015/05/26 21:09:36, achaulk wrote: > > On 2015/05/26 18:20:16, nasko wrote: > > > Is there another gfx header file for this to be included in? Since it is > about > > > swapping buffers, wouldn't ui/gfx/gpu_memory_buffer.h work? > > > > I'm not sure there's an appropriate one really. Gpu memory buffer is a loose > fit > > at best, as it doesn't have any relation to the SwapBuffers path. But I'll > move > > it if you want, it's no big deal > > If it is unrelated, that's fine. I just want to avoid adding a new file for the > sake of one enum. Usually, we have an _enums.h version of the file that > contains the enums used in _messages.h file, so I wanted to see if there is > such a thing for gfx. > > You still need to add this file to the appropriate .gypi file. Added
	11 SWAP_ACK,

	12 SWAP_FAILED,

	13 SWAP_NAK_RECREATE_BUFFERS,

	14 SWAP_RESULT_LAST = SWAP_NAK_RECREATE_BUFFERS,

	15 };

	16

	17 } // namespace gfx

	18

	19 #endif // UI_GFX_SWAP_RESULT_H_

OLD	NEW

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | ui/gl/gl_surface.h » ('j') | no next file with comments »