Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1084173003: Revert of Small refactor around futex.h. (Closed)

Created:
5 years, 8 months ago by dnicoara
Modified:
5 years, 8 months ago
Reviewers:
hidehiko, mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, jln (very slow on Chromium), Mark Seaborn, hamaji, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Small refactor around futex.h. (patchset #1 id:20001 of https://codereview.chromium.org/1076213002/) Reason for revert: Breaks ChromeOS veyron_jerry boot. BUG=477352 Original issue's description: > Small refactor around futex.h. > > This is the preparation of seccomp-bpf implementation > for nacl_helper_nonsfi. > PNaCl toolchain does not provides linux/futex.h. > This CL is the preparation to reuse android_futex.h > for PNaCl toolchain, too. > > TEST=Ran bots. > BUG=358465 > > Committed: https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591 > Cr-Commit-Position: refs/heads/master@{#324996} TBR=mdempsky@chromium.org,hidehiko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358465 Committed: https://crrev.com/4c05c94295ee26adffe966678719085f02b15f2f Cr-Commit-Position: refs/heads/master@{#325265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -86 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 2 chunks +3 lines, -1 line 0 comments Download
A sandbox/linux/system_headers/android_futex.h View 1 chunk +80 lines, -0 lines 0 comments Download
D sandbox/linux/system_headers/linux_futex.h View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dnicoara
Created Revert of Small refactor around futex.h.
5 years, 8 months ago (2015-04-15 17:22:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084173003/1
5 years, 8 months ago (2015-04-15 17:23:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 17:25:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c05c94295ee26adffe966678719085f02b15f2f Cr-Commit-Position: refs/heads/master@{#325265}
5 years, 8 months ago (2015-04-15 17:26:09 UTC) #4
dnicoara
5 years, 8 months ago (2015-04-15 17:42:04 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1088253002/ by dnicoara@chromium.org.

The reason for reverting is: Sorry, mistake on my part, this CL isn't the
cause..

Powered by Google App Engine
This is Rietveld 408576698