Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: components/content_settings/core/browser/plugins_field_trial.cc

Issue 1084123002: Make DETECT_IMPORTANT_CONTENT the default Plugins content setting based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn fixes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugins/plugins_field_trial.h" 5 #include "components/content_settings/core/browser/plugins_field_trial.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "chrome/common/chrome_switches.h" 9 #include "components/content_settings/core/common/content_settings_switches.h"
10 10
11 namespace content_settings {
12
13 // static
14 const char PluginsFieldTrial::kFieldTrialName[] = "ForcePluginPowerSaver";
15
16 // static
11 ContentSetting PluginsFieldTrial::EffectiveContentSetting( 17 ContentSetting PluginsFieldTrial::EffectiveContentSetting(
12 ContentSettingsType type, 18 ContentSettingsType type,
13 ContentSetting setting) { 19 ContentSetting setting) {
14 if (type != CONTENT_SETTINGS_TYPE_PLUGINS) 20 if (type != CONTENT_SETTINGS_TYPE_PLUGINS)
15 return setting; 21 return setting;
16 22
17 // For Plugins, ASK is obsolete. Show as BLOCK to reflect actual behavior. 23 // For Plugins, ASK is obsolete. Show as BLOCK to reflect actual behavior.
18 if (setting == ContentSetting::CONTENT_SETTING_ASK) 24 if (setting == ContentSetting::CONTENT_SETTING_ASK)
19 return ContentSetting::CONTENT_SETTING_BLOCK; 25 return ContentSetting::CONTENT_SETTING_BLOCK;
20 26
21 // For Plugins, allow flag to override displayed content setting.
22 if (setting == ContentSetting::CONTENT_SETTING_ALLOW &&
23 IsForcePluginPowerSaverEnabled()) {
24 return ContentSetting::CONTENT_SETTING_DETECT_IMPORTANT_CONTENT;
25 }
26
27 return setting; 27 return setting;
28 } 28 }
29 29
30 bool PluginsFieldTrial::IsForcePluginPowerSaverEnabled() { 30 // static
31 bool PluginsFieldTrial::IsPluginPowerSaverEnabled() {
31 const base::CommandLine* cl = base::CommandLine::ForCurrentProcess(); 32 const base::CommandLine* cl = base::CommandLine::ForCurrentProcess();
32 if (cl->HasSwitch(switches::kDisablePluginPowerSaver)) 33 if (cl->HasSwitch(switches::kDisablePluginPowerSaver))
33 return false; 34 return false;
34 if (cl->HasSwitch(switches::kEnablePluginPowerSaver)) 35 if (cl->HasSwitch(switches::kEnablePluginPowerSaver))
35 return true; 36 return true;
36 37
37 std::string group_name = 38 std::string group_name = base::FieldTrialList::FindFullName(kFieldTrialName);
38 base::FieldTrialList::FindFullName("ForcePluginPowerSaver");
39 return !group_name.empty() && group_name != "Disabled"; 39 return !group_name.empty() && group_name != "Disabled";
40 } 40 }
41
42 // static
43 ContentSetting PluginsFieldTrial::GetDefaultPluginsContentSetting() {
44 return IsPluginPowerSaverEnabled() ?
45 ContentSetting::CONTENT_SETTING_DETECT_IMPORTANT_CONTENT :
46 ContentSetting::CONTENT_SETTING_ALLOW;
47 }
48
49 } // namespace content_settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698