Issue 1083943002: When converting Maybe and MaybeLocal values with a check, always check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1083943002: When converting Maybe and MaybeLocal values with a check, always check (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 8 months ago

Reviewers:
dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

When converting Maybe and MaybeLocal values with a check, always check An embedder that wants to avoid the check should use MaybeLocal::ToLocal. BUG=none R=dcarney@chromium.org LOG=y Committed: https://crrev.com/ac23150fd2be43fcda9ad12dc118c6b16d96cdb6 Cr-Commit-Position: refs/heads/master@{#27832}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
	M	include/v8.h	View		4 chunks	+5 lines, -9 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083943002/1

5 years, 8 months ago (2015-04-15 07:06:40 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-15 07:12:12 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ac23150fd2be43fcda9ad12dc118c6b16d96cdb6
Cr-Commit-Position: refs/heads/master@{#27832}