Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: src/typing.cc

Issue 1083933002: Pass load ic state through the Oracle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Adjust defaults. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/typing.h" 5 #include "src/typing.h"
6 6
7 #include "src/frames.h" 7 #include "src/frames.h"
8 #include "src/frames-inl.h" 8 #include "src/frames-inl.h"
9 #include "src/ostreams.h" 9 #include "src/ostreams.h"
10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move 10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 NarrowType(expr, Bounds(Type::None(zone()))); 488 NarrowType(expr, Bounds(Type::None(zone())));
489 } 489 }
490 490
491 491
492 void AstTyper::VisitProperty(Property* expr) { 492 void AstTyper::VisitProperty(Property* expr) {
493 // Collect type feedback. 493 // Collect type feedback.
494 FeedbackVectorICSlot slot(FeedbackVectorICSlot::Invalid()); 494 FeedbackVectorICSlot slot(FeedbackVectorICSlot::Invalid());
495 TypeFeedbackId id(TypeFeedbackId::None()); 495 TypeFeedbackId id(TypeFeedbackId::None());
496 if (FLAG_vector_ics) { 496 if (FLAG_vector_ics) {
497 slot = expr->PropertyFeedbackSlot(); 497 slot = expr->PropertyFeedbackSlot();
498 expr->set_is_uninitialized(oracle()->LoadIsUninitialized(slot)); 498 expr->set_inline_cache_state(oracle()->LoadInlineCacheState(slot));
499 } else { 499 } else {
500 id = expr->PropertyFeedbackId(); 500 id = expr->PropertyFeedbackId();
501 expr->set_is_uninitialized(oracle()->LoadIsUninitialized(id)); 501 expr->set_inline_cache_state(oracle()->LoadInlineCacheState(id));
502 } 502 }
503 503
504 if (!expr->IsUninitialized()) { 504 if (!expr->IsUninitialized()) {
505 if (expr->key()->IsPropertyName()) { 505 if (expr->key()->IsPropertyName()) {
506 Literal* lit_key = expr->key()->AsLiteral(); 506 Literal* lit_key = expr->key()->AsLiteral();
507 DCHECK(lit_key != NULL && lit_key->value()->IsString()); 507 DCHECK(lit_key != NULL && lit_key->value()->IsString());
508 Handle<String> name = Handle<String>::cast(lit_key->value()); 508 Handle<String> name = Handle<String>::cast(lit_key->value());
509 if (FLAG_vector_ics) { 509 if (FLAG_vector_ics) {
510 oracle()->PropertyReceiverTypes(slot, name, expr->GetReceiverTypes()); 510 oracle()->PropertyReceiverTypes(slot, name, expr->GetReceiverTypes());
511 } else { 511 } else {
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 822 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
823 } 823 }
824 824
825 825
826 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 826 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
827 RECURSE(Visit(stmt->body())); 827 RECURSE(Visit(stmt->body()));
828 } 828 }
829 829
830 830
831 } } // namespace v8::internal 831 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698