Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1083933002: Pass load ic state through the Oracle. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass load ic state through the Oracle. We'd like to know in optimized code with more precision what feedback state was achieved for a load. R=dcarney@chromium.org BUG= Committed: https://crrev.com/4598f1d376933e4228c4af4afc69b56b98a1f451 Cr-Commit-Position: refs/heads/master@{#27826}

Patch Set 1 #

Patch Set 2 : Adjust defaults. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M src/ast.h View 4 chunks +11 lines, -8 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/type-info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-info.cc View 1 1 chunk +13 lines, -11 lines 0 comments Download
M src/typing.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Dan, here is the work for loads. I'll follow up with stores, which should ...
5 years, 8 months ago (2015-04-14 14:26:33 UTC) #1
dcarney
lgtm
5 years, 8 months ago (2015-04-14 18:02:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083933002/20001
5 years, 8 months ago (2015-04-15 01:16:35 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 01:24:46 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 01:24:56 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4598f1d376933e4228c4af4afc69b56b98a1f451
Cr-Commit-Position: refs/heads/master@{#27826}

Powered by Google App Engine
This is Rietveld 408576698