Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1083883002: Add a unittest that DeleteAll(CookieMonster*) does flush (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a unittest that DeleteAll(CookieMonster*) does flush The unittest ensure that DeleteAll(CookieMonster*) does flush and that the flush_count is valid after DeleteAll() calls. BUG=None Committed: https://crrev.com/444025d2c345aa933460f6e5814fe2b205f2225b Cr-Commit-Position: refs/heads/master@{#325437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M net/cookies/cookie_monster_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
erikwright: this is a test that we have downstream (iOS only) and that I think ...
5 years, 8 months ago (2015-04-14 08:52:51 UTC) #2
erikwright (departed)
LGTM.
5 years, 8 months ago (2015-04-16 13:13:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083883002/1
5 years, 8 months ago (2015-04-16 13:29:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 13:59:20 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 14:00:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/444025d2c345aa933460f6e5814fe2b205f2225b
Cr-Commit-Position: refs/heads/master@{#325437}

Powered by Google App Engine
This is Rietveld 408576698