Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1083833002: win: fix narrowing warning on vs2015 (Closed)

Created:
5 years, 8 months ago by scottmg
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: fix narrowing warning on vs2015 d:\src\cr3\src\ui\platform_window\win\win_window.cc(119): warning C4838: conversion from 'LONG' to 'DWORD' requires a narrowing conversion R=sky@chromium.org BUG=440500 Committed: https://crrev.com/54732d89d4fc5bf21936d029d9505a3795714026 Cr-Commit-Position: refs/heads/master@{#324970}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/platform_window/win/win_window.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 8 months ago (2015-04-13 22:39:20 UTC) #1
sky
LGTM https://codereview.chromium.org/1083833002/diff/1/ui/platform_window/win/win_window.cc File ui/platform_window/win/win_window.cc (right): https://codereview.chromium.org/1083833002/diff/1/ui/platform_window/win/win_window.cc#newcode119 ui/platform_window/win/win_window.cc:119: static_cast<DWORD>(GetMessageTime()), Wow, weird that GetMessageTime() isn't typed to ...
5 years, 8 months ago (2015-04-13 22:51:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083833002/1
5 years, 8 months ago (2015-04-13 23:04:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 00:55:19 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 00:57:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54732d89d4fc5bf21936d029d9505a3795714026
Cr-Commit-Position: refs/heads/master@{#324970}

Powered by Google App Engine
This is Rietveld 408576698