Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/js/nodes.dart

Issue 1083763003: refactor emitMemberName to be used more consistently (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/codegen/js_codegen.dart ('K') | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/cascade.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/js/nodes.dart
diff --git a/lib/src/js/nodes.dart b/lib/src/js/nodes.dart
index 808ff3cdbf7a9447ca1b9454512f78a1ee621b57..fcd569449338ada8deba3a520874f5ae868c898b 100644
--- a/lib/src/js/nodes.dart
+++ b/lib/src/js/nodes.dart
@@ -1078,7 +1078,9 @@ class LiteralString extends Literal {
* TODO(sra): Introduce variants for known valid strings that don't allocate a
* new string just to add quotes.
*/
- LiteralString(this.value);
+ LiteralString(this.value) {
+ assert(value != '"_nextCallback="');
Jacob 2015/04/13 23:19:36 this seems like an oddly specific assert.
Jennifer Messerly 2015/04/14 21:21:00 eeeep. Good catch! I didn't follow my own conventi
+ }
accept(NodeVisitor visitor) => visitor.visitLiteralString(this);
LiteralString _clone() => new LiteralString(value);
« lib/src/codegen/js_codegen.dart ('K') | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/cascade.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698