Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: lib/runtime/dart/_isolate_helper.js

Issue 1083763003: refactor emitMemberName to be used more consistently (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_internal.js ('k') | lib/runtime/dart/_js_helper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_isolate_helper.js
diff --git a/lib/runtime/dart/_isolate_helper.js b/lib/runtime/dart/_isolate_helper.js
index 44a4ba325af534eeabe198217136b7eb24e82d1b..d6086f141174dedddbf33cc782361ddad10b9fc3 100644
--- a/lib/runtime/dart/_isolate_helper.js
+++ b/lib/runtime/dart/_isolate_helper.js
@@ -19,8 +19,8 @@ var _isolate_helper;
let _workerId = Symbol('_workerId');
let _isolateId = Symbol('_isolateId');
let _receivePortId = Symbol('_receivePortId');
- let _receivePort = Symbol('_receivePort');
let _id = Symbol('_id');
+ let _receivePort = Symbol('_receivePort');
let _getJSFunctionName = Symbol('_getJSFunctionName');
class _Serializer extends core.Object {
_Serializer(opts) {
@@ -70,7 +70,7 @@ var _isolate_helper;
return new core.List.from(["ref", serializationId]);
}
isPrimitive(x) {
- return dart.notNull(x == null) || dart.notNull(typeof x == 'string') || dart.notNull(dart.is(x, core.num)) || dart.notNull(typeof x == 'boolean');
+ return dart.notNull(x == null) || typeof x == 'string' || dart.is(x, core.num) || typeof x == 'boolean';
}
serializePrimitive(primitive) {
return primitive;
@@ -229,7 +229,7 @@ var _isolate_helper;
}
}
isPrimitive(x) {
- return dart.notNull(x == null) || dart.notNull(typeof x == 'string') || dart.notNull(dart.is(x, core.num)) || dart.notNull(typeof x == 'boolean');
+ return dart.notNull(x == null) || typeof x == 'string' || dart.is(x, core.num) || typeof x == 'boolean';
}
deserializePrimitive(x) {
return x;
@@ -1133,7 +1133,7 @@ var _isolate_helper;
this[_isolateId] = isolateId$;
}
[_checkReplyTo](replyTo) {
- if (dart.notNull(replyTo != null) && dart.notNull(!dart.is(replyTo, _NativeJsSendPort)) && dart.notNull(!dart.is(replyTo, _WorkerSendPort))) {
+ if (dart.notNull(replyTo != null) && !dart.is(replyTo, _NativeJsSendPort) && !dart.is(replyTo, _WorkerSendPort)) {
throw new core.Exception("SendPort.send: Illegal replyTo port type");
}
}
@@ -1164,7 +1164,7 @@ var _isolate_helper;
}).bind(this), `receive ${message}`);
}
['=='](other) {
- return dart.notNull(dart.is(other, _NativeJsSendPort)) && dart.notNull(dart.equals(this[_receivePort], dart.dload(other, '_receivePort')));
+ return dart.is(other, _NativeJsSendPort) && dart.notNull(dart.equals(this[_receivePort], dart.dload(other, _receivePort)));
}
get hashCode() {
return this[_receivePort][_id];
@@ -1189,7 +1189,7 @@ var _isolate_helper;
}
}
['=='](other) {
- return dart.notNull(dart.is(other, _WorkerSendPort)) && dart.equals(this[_workerId], dart.dload(other, '_workerId')) && dart.equals(this[_isolateId], dart.dload(other, '_isolateId')) && dart.equals(this[_receivePortId], dart.dload(other, '_receivePortId'));
+ return dart.is(other, _WorkerSendPort) && dart.equals(this[_workerId], dart.dload(other, _workerId)) && dart.equals(this[_isolateId], dart.dload(other, _isolateId)) && dart.equals(this[_receivePortId], dart.dload(other, _receivePortId));
}
get hashCode() {
return dart.notNull(this[_workerId]) << 16 ^ dart.notNull(this[_isolateId]) << 8 ^ dart.notNull(this[_receivePortId]);
« no previous file with comments | « lib/runtime/dart/_internal.js ('k') | lib/runtime/dart/_js_helper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698