refactor emitMemberName to be used more consistently

lib/runtime/dart/_internal.js

 var _internal;
 (function(exports) {
   'use strict';
   class EfficientLength extends core.Object {}
   let ListIterable$ = dart.generic(function(E) {
     class ListIterable extends collection.IterableBase$(E) {
       ListIterable() {
         super.IterableBase();
       }
       get [core.$iterator]() {
         return new (ListIterator$(E))(this);
       }
       [core.$forEach](action) {
         let length = this[core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          action(this.elementAt(i));
+          action(this[core.$elementAt](i));
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
       }
       get [core.$isEmpty]() {
-        return this.length == 0;
+        return this[core.$length] == 0;
       }
       get [core.$first]() {
-        if (this.length == 0)
+        if (this[core.$length] == 0)

[Jacob, 2015/04/13 23:19:35]

nice. glad this case is fixed.

           throw IterableElementError.noElement();
-        return this.elementAt(0);
+        return this[core.$elementAt](0);
       }
       get [core.$last]() {
-        if (this.length == 0)
+        if (this[core.$length] == 0)
           throw IterableElementError.noElement();
-        return this.elementAt(dart.notNull(this.length) - 1);
+        return this[core.$elementAt](dart.notNull(this[core.$length]) - 1);
       }
       get [core.$single]() {
-        if (this.length == 0)
+        if (this[core.$length] == 0)
           throw IterableElementError.noElement();
-        if (dart.notNull(this.length) > 1)
+        if (dart.notNull(this[core.$length]) > 1)
           throw IterableElementError.tooMany();
-        return this.elementAt(0);
+        return this[core.$elementAt](0);
       }
       [core.$contains](element) {
         let length = this[core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          if (dart.equals(this.elementAt(i), element))
+          if (dart.equals(this[core.$elementAt](i), element))
             return true;
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         return false;
       }
       [core.$every](test) {
         let length = this[core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          if (!dart.notNull(test(this.elementAt(i))))
+          if (!dart.notNull(test(this[core.$elementAt](i))))
             return false;
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         return true;
       }
       [core.$any](test) {
         let length = this[core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          if (test(this.elementAt(i)))
+          if (test(this[core.$elementAt](i)))
             return true;
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         return false;
       }
       [core.$firstWhere](test, opts) {
         let orElse = opts && 'orElse' in opts ? opts.orElse : null;
         let length = this[core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          let element = this.elementAt(i);
+          let element = this[core.$elementAt](i);
           if (test(element))
             return element;
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         if (orElse != null)
           return orElse();
         throw IterableElementError.noElement();
       }
       [core.$lastWhere](test, opts) {
         let orElse = opts && 'orElse' in opts ? opts.orElse : null;
         let length = this[core.$length];
         for (let i = dart.notNull(length) - 1; dart.notNull(i) >= 0; i = dart.notNull(i) - 1) {
-          let element = this.elementAt(i);
+          let element = this[core.$elementAt](i);
           if (test(element))
             return element;
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         if (orElse != null)
           return orElse();
         throw IterableElementError.noElement();
       }
       [core.$singleWhere](test) {
         let length = this[core.$length];
         let match = null;
         let matchFound = false;
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          let element = this.elementAt(i);
+          let element = this[core.$elementAt](i);
           if (test(element)) {
             if (matchFound) {
               throw IterableElementError.tooMany();
             }
             matchFound = true;
             match = element;
           }
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         if (matchFound)
           return match;
         throw IterableElementError.noElement();
       }
       [core.$join](separator) {
         if (separator === void 0)
           separator = "";
         let length = this[core.$length];
         if (!dart.notNull(separator.isEmpty)) {
           if (length == 0)
             return "";
-          let first = `${this.elementAt(0)}`;
+          let first = `${this[core.$elementAt](0)}`;
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
           let buffer = new core.StringBuffer(first);
           for (let i = 1; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
             buffer.write(separator);
-            buffer.write(this.elementAt(i));
+            buffer.write(this[core.$elementAt](i));
             if (length != this[core.$length]) {
               throw new core.ConcurrentModificationError(this);
             }
           }
           return buffer.toString();
         } else {
           let buffer = new core.StringBuffer();
           for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-            buffer.write(this.elementAt(i));
+            buffer.write(this[core.$elementAt](i));
             if (length != this[core.$length]) {
               throw new core.ConcurrentModificationError(this);
             }
           }
           return buffer.toString();
         }
       }
       [core.$where](test) {
         return super[core.$where](test);
       }
       [core.$map](f) {
         return new MappedListIterable(this, f);
       }
       [core.$reduce](combine) {
         let length = this[core.$length];
         if (length == 0)
           throw IterableElementError.noElement();
-        let value = this.elementAt(0);
+        let value = this[core.$elementAt](0);
         for (let i = 1; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          value = dart.dinvokef(combine, value, this.elementAt(i));
+          value = dart.dinvokef(combine, value, this[core.$elementAt](i));
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         return value;
       }
       [core.$fold](initialValue, combine) {
         let value = initialValue;
         let length = this[core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
-          value = dart.dinvokef(combine, value, this.elementAt(i));
+          value = dart.dinvokef(combine, value, this[core.$elementAt](i));
           if (length != this[core.$length]) {
             throw new core.ConcurrentModificationError(this);
           }
         }
         return value;
       }
       [core.$skip](count) {
         return new (SubListIterable$(E))(this, count, null);
       }
       [core.$skipWhile](test) {
         return super[core.$skipWhile](test);
       }
       [core.$take](count) {
         return new (SubListIterable$(E))(this, 0, count);
       }
       [core.$takeWhile](test) {
         return super[core.$takeWhile](test);
       }
       [core.$toList](opts) {
         let growable = opts && 'growable' in opts ? opts.growable : true;
         let result = null;
         if (growable) {
           result = new (core.List$(E))();
-          result[core.$length] = this.length;
+          result[core.$length] = this[core.$length];
         } else {
-          result = new (core.List$(E))(this.length);
+          result = new (core.List$(E))(this[core.$length]);
         }
-        for (let i = 0; dart.notNull(i) < dart.notNull(this.length); i = dart.notNull(i) + 1) {
-          result[core.$set](i, this.elementAt(i));
+        for (let i = 0; dart.notNull(i) < dart.notNull(this[core.$length]); i = dart.notNull(i) + 1) {
+          result[core.$set](i, this[core.$elementAt](i));
         }
         return result;
       }
       [core.$toSet]() {
         let result = new (core.Set$(E))();
-        for (let i = 0; dart.notNull(i) < dart.notNull(this.length); i = dart.notNull(i) + 1) {
-          result.add(this.elementAt(i));
+        for (let i = 0; dart.notNull(i) < dart.notNull(this[core.$length]); i = dart.notNull(i) + 1) {
+          result.add(this[core.$elementAt](i));
         }
         return result;
       }
     }
     ListIterable[dart.implements] = () => [EfficientLength];
     return ListIterable;
   });
   let ListIterable = ListIterable$();
   let _iterable = dart.JsSymbol('_iterable');
   let _start = dart.JsSymbol('_start');
@@ skipping 309 matching lines @@
       }
     }
     ExpandIterator[dart.implements] = () => [core.Iterator$(T)];
     return ExpandIterator;
   });
   let ExpandIterator = ExpandIterator$();
   let _takeCount = dart.JsSymbol('_takeCount');
   let TakeIterable$ = dart.generic(function(E) {
     class TakeIterable extends collection.IterableBase$(E) {
       TakeIterable(iterable, takeCount) {
-        if (dart.notNull(!(typeof takeCount == 'number')) || dart.notNull(takeCount) < 0) {
+        if (!(typeof takeCount == 'number') || dart.notNull(takeCount) < 0) {
           throw new core.ArgumentError(takeCount);
         }
         if (dart.is(iterable, EfficientLength)) {
           return new (EfficientLengthTakeIterable$(E))(iterable, takeCount);
         }
         return new TakeIterable$(E)[_](iterable, takeCount);
       }
       [_](iterable$, takeCount$) {
         this[_iterable] = iterable$;
         this[_takeCount] = takeCount$;
@@ skipping 23 matching lines @@
     return EfficientLengthTakeIterable;
   });
   let EfficientLengthTakeIterable = EfficientLengthTakeIterable$();
   let _remaining = dart.JsSymbol('_remaining');
   let TakeIterator$ = dart.generic(function(E) {
     class TakeIterator extends core.Iterator$(E) {
       TakeIterator(iterator$, remaining) {
         this[_iterator] = iterator$;
         this[_remaining] = remaining;
         super.Iterator();
-        dart.assert(dart.notNull(typeof this[_remaining] == 'number') && dart.notNull(this[_remaining]) >= 0);
+        dart.assert(typeof this[_remaining] == 'number' && dart.notNull(this[_remaining]) >= 0);
       }
       moveNext() {
         this[_remaining] = dart.notNull(this[_remaining]) - 1;
         if (dart.notNull(this[_remaining]) >= 0) {
           return this[_iterator].moveNext();
         }
         this[_remaining] = -1;
         return false;
       }
       get current() {
@@ skipping 94 matching lines @@
     EfficientLengthSkipIterable[dart.implements] = () => [EfficientLength];
     return EfficientLengthSkipIterable;
   });
   let EfficientLengthSkipIterable = EfficientLengthSkipIterable$();
   let SkipIterator$ = dart.generic(function(E) {
     class SkipIterator extends core.Iterator$(E) {
       SkipIterator(iterator$, skipCount$) {
         this[_iterator] = iterator$;
         this[_skipCount] = skipCount$;
         super.Iterator();
-        dart.assert(dart.notNull(typeof this[_skipCount] == 'number') && dart.notNull(this[_skipCount]) >= 0);
+        dart.assert(typeof this[_skipCount] == 'number' && dart.notNull(this[_skipCount]) >= 0);
       }
       moveNext() {
         for (let i = 0; dart.notNull(i) < dart.notNull(this[_skipCount]); i = dart.notNull(i) + 1)
           this[_iterator].moveNext();
         this[_skipCount] = 0;
         return this[_iterator].moveNext();
       }
       get current() {
         return this[_iterator].current;
       }
@@ skipping 697 matching lines @@
       get isEmpty() {
         return this[_values][core.$isEmpty];
       }
       get isNotEmpty() {
         return this[_values][core.$isNotEmpty];
       }
       containsValue(value) {
         return this[_values][core.$contains](value);
       }
       containsKey(key) {
-        return dart.notNull(typeof key == 'number') && dart.notNull(key) >= 0 && dart.notNull(key) < dart.notNull(this.length);
+        return typeof key == 'number' && dart.notNull(key) >= 0 && dart.notNull(key) < dart.notNull(this.length);
       }
       forEach(f) {
         let length = this[_values][core.$length];
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
           f(i, this[_values][core.$get](i));
           if (length != this[_values][core.$length]) {
             throw new core.ConcurrentModificationError(this[_values]);
           }
         }
       }
@@ skipping 74 matching lines @@
         }
       } else {
         for (let i = srcStart, j = dstStart; dart.notNull(i) < dart.notNull(srcStart) + dart.notNull(count); i = dart.notNull(i) + 1, j = dart.notNull(j) + 1) {
           dst[core.$set](j, src[core.$get](i));
         }
       }
     }
     static areEqual(a, b) {
       if (core.identical(a, b))
         return true;
-      if (!dart.notNull(dart.is(b, core.List)))
+      if (!dart.is(b, core.List))
         return false;
       let length = a[core.$length];
       if (!dart.equals(length, dart.dload(b, 'length')))
         return false;
       for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
         if (!dart.notNull(core.identical(a[core.$get](i), dart.dindex(b, i))))
           return false;
       }
       return true;
     }
@@ skipping 310 matching lines @@
     Symbol(name) {
       this[_name] = name;
     }
     unvalidated(name$) {
       this[_name] = name$;
     }
     validated(name) {
       this[_name] = Symbol.validatePublicSymbol(name);
     }
     ['=='](other) {
-      return dart.notNull(dart.is(other, Symbol)) && dart.notNull(dart.equals(this[_name], dart.dload(other, '_name')));
+      return dart.is(other, Symbol) && dart.notNull(dart.equals(this[_name], dart.dload(other, _name)));
     }
     get hashCode() {
       let arbitraryPrime = 664597;
       return 536870911 & dart.notNull(arbitraryPrime) * dart.notNull(this[_name].hashCode);
     }
     toString() {
       return `Symbol("${this[_name]}")`;
     }
     static getName(symbol) {
       return symbol[_name];
@@ skipping 93 matching lines @@
   exports.ReversedListIterable = ReversedListIterable;
   exports.UnmodifiableListError = UnmodifiableListError;
   exports.NonGrowableListError = NonGrowableListError;
   exports.makeListFixedLength = makeListFixedLength;
   exports.Lists = Lists;
   exports.printToConsole = printToConsole;
   exports.Sort = Sort;
   exports.Symbol = Symbol;
   exports.POWERS_OF_TEN = POWERS_OF_TEN;
 })(_internal || (_internal = {}));