refactor emitMemberName to be used more consistently

lib/runtime/dart/_js_helper.js

 var _js_helper;
 (function(exports) {
   'use strict';
   class NoSideEffects extends core.Object {
     NoSideEffects() {
     }
   }
   class NoThrows extends core.Object {
     NoThrows() {
     }
@@ skipping 718 matching lines @@
       return dart.dload(dart.dsend(other, 'allMatches', substr), 'isNotEmpty');
     }
   }
   // Function stringReplaceJS: (dynamic, dynamic, dynamic) → dynamic
   function stringReplaceJS(receiver, replacer, to) {
     to = to.replace(/\$/g, "$$$$");
     return receiver.replace(replacer, to);
   }
   // Function stringReplaceFirstRE: (dynamic, dynamic, dynamic, dynamic) → dynamic
   function stringReplaceFirstRE(receiver, regexp, to, startIndex) {
-    let match = dart.dsend(regexp, '_execGlobal', receiver, startIndex);
+    let match = dart.dsend(regexp, _execGlobal, receiver, startIndex);
     if (match == null)
       return receiver;
     let start = dart.dload(match, 'start');
     let end = dart.dload(match, 'end');
     return `${dart.dsend(receiver, 'substring', 0, start)}${to}${dart.dsend(receiver, 'substring', end)}`;
   }
   let ESCAPE_REGEXP = '[[\\]{}()*+?.\\\\^$|]';
   // Function stringReplaceAllUnchecked: (dynamic, dynamic, dynamic) → dynamic
   function stringReplaceAllUnchecked(receiver, from, to) {
     checkString(to);
@@ skipping 134 matching lines @@
     toString() {
       if (this[_unmangledName] != null)
         return this[_unmangledName];
       let unmangledName = _js_names.unmangleAllIdentifiersIfPreservedAnyways(this[_typeName]);
       return this[_unmangledName] = unmangledName;
     }
     get hashCode() {
       return this[_typeName].hashCode;
     }
     ['=='](other) {
-      return dart.notNull(dart.is(other, TypeImpl)) && dart.notNull(dart.equals(this[_typeName], dart.dload(other, '_typeName')));
+      return dart.is(other, TypeImpl) && dart.notNull(dart.equals(this[_typeName], dart.dload(other, _typeName)));
     }
   }
   TypeImpl[dart.implements] = () => [core.Type];
   class TypeVariable extends core.Object {
     TypeVariable(owner, name, bound) {
       this.owner = owner;
       this.name = name;
       this.bound = bound;
     }
   }
@@ skipping 1099 matching lines @@
     }
     static valueFromDateString(str) {
       if (!(typeof str == 'string'))
         throw new core.ArgumentError(str);
       let value = Date.parse(str);
       if (value.isNaN)
         throw new core.ArgumentError(str);
       return value;
     }
     static getProperty(object, key) {
-      if (dart.notNull(object == null) || dart.notNull(typeof object == 'boolean') || dart.notNull(dart.is(object, core.num)) || dart.notNull(typeof object == 'string')) {
+      if (dart.notNull(object == null) || typeof object == 'boolean' || dart.is(object, core.num) || typeof object == 'string') {
         throw new core.ArgumentError(object);
       }
       return object[key];
     }
     static setProperty(object, key, value) {
-      if (dart.notNull(object == null) || dart.notNull(typeof object == 'boolean') || dart.notNull(dart.is(object, core.num)) || dart.notNull(typeof object == 'string')) {
+      if (dart.notNull(object == null) || typeof object == 'boolean' || dart.is(object, core.num) || typeof object == 'string') {
         throw new core.ArgumentError(object);
       }
       object[key] = value;
     }
     static functionNoSuchMethod(func, positionalArguments, namedArguments) {
       let argumentCount = 0;
       let arguments$ = new core.List.from([]);
       let namedArgumentList = new core.List.from([]);
       if (positionalArguments != null) {
         argumentCount = dart.notNull(argumentCount) + dart.notNull(positionalArguments[core.$length]);
@@ skipping 455 matching lines @@
         return saveStackTrace(new JsNoSuchMethodError(dart.as(message, core.String), match));
       } else if ((match = dart.dsend(notClosure, 'matchTypeError', message)) != null) {
         match.method = "call";
         return saveStackTrace(new JsNoSuchMethodError(dart.as(message, core.String), match));
       } else if (dart.notNull((match = dart.dsend(nullCall, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(nullLiteralCall, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(undefCall, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(undefLiteralCall, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(nullProperty, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(nullLiteralCall, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(undefProperty, 'matchTypeError', message)) != null) || dart.notNull((match = dart.dsend(undefLiteralProperty, 'matchTypeError', message)) != null)) {
         return saveStackTrace(new NullError(dart.as(message, core.String), match));
       }
       return saveStackTrace(new UnknownJsTypeError(dart.as(typeof message == 'string' ? message : '', core.String)));
     }
     if (ex instanceof RangeError) {
-      if (dart.notNull(typeof message == 'string') && dart.notNull(contains(dart.as(message, core.String), 'call stack'))) {
+      if (typeof message == 'string' && dart.notNull(contains(dart.as(message, core.String), 'call stack'))) {
         return new core.StackOverflowError();
       }
       return saveStackTrace(new core.ArgumentError());
     }
     if (typeof InternalError == "function" && ex instanceof InternalError) {
-      if (dart.notNull(typeof message == 'string') && dart.notNull(dart.equals(message, 'too much recursion'))) {
+      if (typeof message == 'string' && dart.notNull(dart.equals(message, 'too much recursion'))) {
         return new core.StackOverflowError();
       }
     }
     return ex;
   }
   // Function getTraceFromException: (dynamic) → StackTrace
   function getTraceFromException(exception) {
     return new _StackTrace(exception);
   }
   let _exception = Symbol('_exception');
@@ skipping 353 matching lines @@
       this[_target] = target$;
       this[_receiver] = receiver$;
       this[_name] = name$;
       super.TearOffClosure();
     }
     ['=='](other) {
       if (core.identical(this, other))
         return true;
       if (!dart.is(other, BoundClosure))
         return false;
-      return this[_self] === dart.dload(other, '_self') && this[_target] === dart.dload(other, '_target') && this[_receiver] === dart.dload(other, '_receiver');
+      return this[_self] === dart.dload(other, _self) && this[_target] === dart.dload(other, _target) && this[_receiver] === dart.dload(other, _receiver);
     }
     get hashCode() {
       let receiverHashCode = null;
       if (this[_receiver] == null) {
         receiverHashCode = Primitives.objectHashCode(this[_self]);
       } else if (typeof this[_receiver] != 'object') {
         receiverHashCode = this[_receiver].hashCode;
       } else {
         receiverHashCode = Primitives.objectHashCode(this[_receiver]);
       }
@@ skipping 74 matching lines @@
   // Function stringTypeCheck: (dynamic) → dynamic
   function stringTypeCheck(value) {
     if (value == null)
       return value;
     if (typeof value == 'string')
       return value;
     throw new TypeErrorImplementation(value, 'String');
   }
   // Function stringTypeCast: (dynamic) → dynamic
   function stringTypeCast(value) {
-    if (dart.notNull(typeof value == 'string') || dart.notNull(value == null))
+    if (typeof value == 'string' || dart.notNull(value == null))
       return value;
     throw new CastErrorImplementation(Primitives.objectTypeName(value), 'String');
   }
   // Function doubleTypeCheck: (dynamic) → dynamic
   function doubleTypeCheck(value) {
     if (value == null)
       return value;
     if (typeof value == 'number')
       return value;
     throw new TypeErrorImplementation(value, 'double');
   }
   // Function doubleTypeCast: (dynamic) → dynamic
   function doubleTypeCast(value) {
-    if (dart.notNull(typeof value == 'number') || dart.notNull(value == null))
+    if (typeof value == 'number' || dart.notNull(value == null))
       return value;
     throw new CastErrorImplementation(Primitives.objectTypeName(value), 'double');
   }
   // Function numTypeCheck: (dynamic) → dynamic
   function numTypeCheck(value) {
     if (value == null)
       return value;
     if (dart.is(value, core.num))
       return value;
     throw new TypeErrorImplementation(value, 'num');
   }
   // Function numTypeCast: (dynamic) → dynamic
   function numTypeCast(value) {
-    if (dart.notNull(dart.is(value, core.num)) || dart.notNull(value == null))
+    if (dart.is(value, core.num) || dart.notNull(value == null))
       return value;
     throw new CastErrorImplementation(Primitives.objectTypeName(value), 'num');
   }
   // Function boolTypeCheck: (dynamic) → dynamic
   function boolTypeCheck(value) {
     if (value == null)
       return value;
     if (typeof value == 'boolean')
       return value;
     throw new TypeErrorImplementation(value, 'bool');
   }
   // Function boolTypeCast: (dynamic) → dynamic
   function boolTypeCast(value) {
-    if (dart.notNull(typeof value == 'boolean') || dart.notNull(value == null))
+    if (typeof value == 'boolean' || dart.notNull(value == null))
       return value;
     throw new CastErrorImplementation(Primitives.objectTypeName(value), 'bool');
   }
   // Function intTypeCheck: (dynamic) → dynamic
   function intTypeCheck(value) {
     if (value == null)
       return value;
     if (typeof value == 'number')
       return value;
     throw new TypeErrorImplementation(value, 'int');
   }
   // Function intTypeCast: (dynamic) → dynamic
   function intTypeCast(value) {
-    if (dart.notNull(typeof value == 'number') || dart.notNull(value == null))
+    if (typeof value == 'number' || dart.notNull(value == null))
       return value;
     throw new CastErrorImplementation(Primitives.objectTypeName(value), 'int');
   }
   // Function propertyTypeError: (dynamic, dynamic) → void
   function propertyTypeError(value, property) {
     let name = dart.as(dart.dsend(property, 'substring', 3, dart.dload(property, 'length')), core.String);
     throw new TypeErrorImplementation(value, name);
   }
   // Function propertyTypeCastError: (dynamic, dynamic) → void
   function propertyTypeCastError(value, property) {
@@ skipping 96 matching lines @@
     if (value == null)
       return value;
     if (typeof value == 'string')
       return value;
     if (_interceptors.getInterceptor(value)[property])
       return value;
     propertyTypeError(value, property);
   }
   // Function stringSuperNativeTypeCast: (dynamic, dynamic) → dynamic
   function stringSuperNativeTypeCast(value, property) {
-    if (dart.notNull(typeof value == 'string') || dart.notNull(value == null))
+    if (typeof value == 'string' || dart.notNull(value == null))
       return value;
     if (_interceptors.getInterceptor(value)[property])
       return value;
     propertyTypeCastError(value, property);
   }
   // Function listTypeCheck: (dynamic) → dynamic
   function listTypeCheck(value) {
     if (value == null)
       return value;
     if (dart.is(value, core.List))
       return value;
     throw new TypeErrorImplementation(value, 'List');
   }
   // Function listTypeCast: (dynamic) → dynamic
   function listTypeCast(value) {
-    if (dart.notNull(dart.is(value, core.List)) || dart.notNull(value == null))
+    if (dart.is(value, core.List) || dart.notNull(value == null))
       return value;
     throw new CastErrorImplementation(Primitives.objectTypeName(value), 'List');
   }
   // Function listSuperTypeCheck: (dynamic, dynamic) → dynamic
   function listSuperTypeCheck(value, property) {
     if (value == null)
       return value;
     if (dart.is(value, core.List))
       return value;
     if (!!value[property])
@@ skipping 11 matching lines @@
     if (value == null)
       return value;
     if (dart.is(value, core.List))
       return value;
     if (_interceptors.getInterceptor(value)[property])
       return value;
     propertyTypeError(value, property);
   }
   // Function listSuperNativeTypeCast: (dynamic, dynamic) → dynamic
   function listSuperNativeTypeCast(value, property) {
-    if (dart.notNull(dart.is(value, core.List)) || dart.notNull(value == null))
+    if (dart.is(value, core.List) || dart.notNull(value == null))
       return value;
     if (_interceptors.getInterceptor(value)[property])
       return value;
     propertyTypeCastError(value, property);
   }
   // Function voidTypeCheck: (dynamic) → dynamic
   function voidTypeCheck(value) {
     if (value == null)
       return value;
     throw new TypeErrorImplementation(value, 'void');
@@ skipping 288 matching lines @@
     let fixedListOrNull = dart.as(x, core.List);
     let fixedListOrNull2 = dart.as(x, core.List);
     let fixedList = dart.as(x, core.List);
     let jsObject = x;
     buildFunctionType(dyn, fixedListOrNull, fixedListOrNull2);
     buildNamedFunctionType(dyn, fixedList, jsObject);
     buildInterfaceType(dyn, fixedListOrNull);
     getDynamicRuntimeType();
     getVoidRuntimeType();
     convertRtiToRuntimeType(dyn);
-    dart.dsend(dyn, '_isTest', dyn2);
-    dart.dsend(dyn, '_asCheck', dyn2);
-    dart.dsend(dyn, '_assertCheck', dyn2);
+    dart.dsend(dyn, _isTest, dyn2);
+    dart.dsend(dyn, _asCheck, dyn2);
+    dart.dsend(dyn, _assertCheck, dyn2);
   }
   // Function convertRtiToRuntimeType: (dynamic) → RuntimeType
   function convertRtiToRuntimeType(rti) {
     if (rti == null) {
       return getDynamicRuntimeType();
     } else if (typeof rti == "function") {
       return new RuntimeTypePlain(rti.name);
     } else if (rti.constructor == Array) {
       let list = dart.as(rti, core.List);
       let name = list[core.$get](0).name;
@@ skipping 529 matching lines @@
   exports.jsonEncodeNative = jsonEncodeNative;
   exports.getIsolateAffinityTag = getIsolateAffinityTag;
   exports.LoadLibraryFunctionType = LoadLibraryFunctionType;
   exports.DeferredLoadCallback = DeferredLoadCallback;
   exports.loadDeferredLibrary = loadDeferredLibrary;
   exports.MainError = MainError;
   exports.missingMain = missingMain;
   exports.badMain = badMain;
   exports.mainHasTooManyParameters = mainHasTooManyParameters;
 })(_js_helper || (_js_helper = {}));