chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc - Issue 10837214: Refactor ModelTypePayloadMap and ObjectIdPayloadMap to StateMaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

Issue 10837214: Refactor ModelTypePayloadMap and ObjectIdPayloadMap to StateMaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc ('k') | chrome/browser/sync/glue/chrome_sync_notification_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

index d468350222a0c0097584e59bb4ecef6ea8f4d2dc..289a6d98fbc74aa8d302a17956b49c290735db1b 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

@@ -159,7 +159,7 @@ TEST_F(PushMessagingInvalidationHandlerTest, Dispatch) {

OnMessage("dddddddddddddddddddddddddddddddd", 0, "payload"));

EXPECT_CALL(delegate_,

OnMessage("dddddddddddddddddddddddddddddddd", 3, "payload"));

- handler_->OnIncomingNotification(ObjectIdSetToPayloadMap(ids, "payload"),

+ handler_->OnIncomingNotification(ObjectIdSetToStateMap(ids, "payload"),

syncer::REMOTE_NOTIFICATION);

}

@@ -190,7 +190,7 @@ TEST_F(PushMessagingInvalidationHandlerTest, DispatchInvalidObjectIds) {

ids.insert(invalidation::ObjectId(

ipc::invalidation::ObjectSource::CHROME_COMPONENTS,

"U/dddddddddddddddddddddddddddddddd/4"));

- handler_->OnIncomingNotification(ObjectIdSetToPayloadMap(ids, "payload"),

+ handler_->OnIncomingNotification(ObjectIdSetToStateMap(ids, "payload"),

syncer::REMOTE_NOTIFICATION);

}