Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083703002: Convert BitmapTextBlob from using STArray to AutoSTMalloc (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@atcolorslots
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert BitmapTextBlob from using STArray to AutoSTMalloc BUG=skia: Committed: https://skia.googlesource.com/skia/+/c3c5990ac0f1063eb92a98b98a71314b5b5ef7e8

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 2 2 chunks +41 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-13 14:17:06 UTC) #3
bsalomon
lgtm
5 years, 8 months ago (2015-04-13 15:06:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083703002/1
5 years, 8 months ago (2015-04-14 19:20:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/487)
5 years, 8 months ago (2015-04-14 19:41:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083703002/40001
5 years, 8 months ago (2015-04-14 21:26:35 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 21:33:40 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c3c5990ac0f1063eb92a98b98a71314b5b5ef7e8

Powered by Google App Engine
This is Rietveld 408576698