Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: sync/test/fake_server/android/fake_server_helper_android.cc

Issue 1083683003: Speculative revert by sheriff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed an unrelated commit that had accidentally slipped in. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/test/fake_server/android/fake_server_helper_android.cc
diff --git a/sync/test/fake_server/android/fake_server_helper_android.cc b/sync/test/fake_server/android/fake_server_helper_android.cc
index 79c0babc2621f34a77a0ed6de2b7427f14e1a26e..cc8fe814a85357f10bc82a224ffbeb39fda9a31d 100644
--- a/sync/test/fake_server/android/fake_server_helper_android.cc
+++ b/sync/test/fake_server/android/fake_server_helper_android.cc
@@ -14,14 +14,11 @@
#include "sync/internal_api/public/base/model_type.h"
#include "sync/internal_api/public/network_resources.h"
#include "sync/protocol/sync.pb.h"
-#include "sync/test/fake_server/bookmark_entity_builder.h"
-#include "sync/test/fake_server/entity_builder_factory.h"
#include "sync/test/fake_server/fake_server.h"
#include "sync/test/fake_server/fake_server_network_resources.h"
#include "sync/test/fake_server/fake_server_verifier.h"
#include "sync/test/fake_server/unique_client_entity.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "url/gurl.h"
FakeServerHelperAndroid::FakeServerHelperAndroid(JNIEnv* env, jobject obj) {
}
@@ -108,44 +105,6 @@ void FakeServerHelperAndroid::InjectUniqueClientEntity(
entity_specifics));
}
-void FakeServerHelperAndroid::InjectBookmarkEntity(
- JNIEnv* env,
- jobject obj,
- jlong fake_server,
- jstring title,
- jstring url,
- jstring parent_id) {
- fake_server::FakeServer* fake_server_ptr =
- reinterpret_cast<fake_server::FakeServer*>(fake_server);
-
- std::string url_as_string = base::android::ConvertJavaStringToUTF8(env, url);
- GURL gurl = GURL(url_as_string);
- if (!gurl.is_valid()) {
- NOTREACHED() << "The given string (" << url_as_string
- << ") is not a valid URL.";
- }
-
- fake_server::EntityBuilderFactory entity_builder_factory;
- fake_server::BookmarkEntityBuilder bookmark_builder =
- entity_builder_factory.NewBookmarkEntityBuilder(
- base::android::ConvertJavaStringToUTF8(env, title), gurl);
- bookmark_builder.SetParentId(
- base::android::ConvertJavaStringToUTF8(env, parent_id));
- scoped_ptr<fake_server::FakeServerEntity> bookmark = bookmark_builder.Build();
- fake_server_ptr->InjectEntity(bookmark.Pass());
-}
-
-base::android::ScopedJavaLocalRef<jstring>
-FakeServerHelperAndroid::GetBookmarkBarFolderId(
- JNIEnv* env,
- jobject obj,
- jlong fake_server) {
- fake_server::FakeServer* fake_server_ptr =
- reinterpret_cast<fake_server::FakeServer*>(fake_server);
- return base::android::ConvertUTF8ToJavaString(
- env, fake_server_ptr->GetBookmarkBarFolderId());
-}
-
// static
bool FakeServerHelperAndroid::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
« no previous file with comments | « sync/test/fake_server/android/fake_server_helper_android.h ('k') | sync/test/fake_server/bookmark_entity_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698