Propagate GN public shared libraries through shared libraries

Propagate GN public shared libraries through shared libraries

Previously all dependencies would stop propagating for link purposes when a shared library or executable boundary is reached.

This patch makes public shared library dependencies propagate through shared libraries. Since the ability to use header files is propagated through these boundaries, so do the link dependencies. See the comment in target.cc for more details.

BUG=475091
Committed: https://crrev.com/54d76753a03e67a980b6cd27f51678cb22d3ef93
Cr-Commit-Position: refs/heads/master@{#325471}

[brettw, 2015-04-15 18:20:02]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-04-15 18:20:07]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 18:20:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083663007/20001

[brettw, 2015-04-15 18:24:29]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 18:26:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083663007/40001

[brettw, 2015-04-15 18:29:40]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 18:30:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083663007/60001

[commit-bot: I haz the power, 2015-04-15 18:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 18:43:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2015-04-15 19:31:39]

lgtm w/ nits. Also, a question.

https://codereview.chromium.org/1083663007/diff/60001/tools/gn/inherited_libr...
File tools/gn/inherited_libraries.cc (right):

https://codereview.chromium.org/1083663007/diff/60001/tools/gn/inherited_libr...
tools/gn/inherited_libraries.cc:10: 
nit: stray blank line?

https://codereview.chromium.org/1083663007/diff/60001/tools/gn/inherited_libr...
File tools/gn/inherited_libraries.h (right):

https://codereview.chromium.org/1083663007/diff/60001/tools/gn/inherited_libr...
tools/gn/inherited_libraries.h:17: // a given target. These are pushed up the
dependency tree.
why is ordered important?

https://codereview.chromium.org/1083663007/diff/60001/tools/gn/target.h
File tools/gn/target.h (right):

https://codereview.chromium.org/1083663007/diff/60001/tools/gn/target.h#newco...
tools/gn/target.h:286: // Static libraries, shared, libraries, and source sets
from transitive deps
nit: extra comma after "shared"?

[brettw, 2015-04-16 17:07:06]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-04-16 17:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1083663007/#ps80001
(title: "review comments")

[commit-bot: I haz the power, 2015-04-16 17:07:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083663007/80001

[commit-bot: I haz the power, 2015-04-16 17:41:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-16 17:41:51]

Patchset 5 (id:??) landed as
https://crrev.com/54d76753a03e67a980b6cd27f51678cb22d3ef93
Cr-Commit-Position: refs/heads/master@{#325471}