Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1083663004: Revert of Move the event attach/detach logic on unload from event.js to (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move the event attach/detach logic on unload from event.js to (patchset #7 id:130001 of https://codereview.chromium.org/1074273002/) Reason for revert: This is breaking ExtensionApiTest.EventsAreUnregistered on Win7 Dedubg bots. See: https://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/16162 Original issue's description: > Move the event attach/detach logic on unload from event.js to > event_bindings.cc. > > This removes one of the reasons to call into JavaScript on context unload, > which can crash. It's also more robust; it's confusing trying to maintain a > data structure in JavaScript which reflects C++ state, which contributes to > bugs like crbug.com/474718. > > Also clean up and formalise the script context invalidation system: CHECK > rather than guarding against multiple invalidations, only invalidate script > context related member variables, add an invalidation observer interface. > > BUG=474718, 475536 > R=rdevlin.cronin@chromium.org > > Committed: https://crrev.com/d99095034d2e88897ae82c8353f3327a3a1d03a5 > Cr-Commit-Position: refs/heads/master@{#324933} TBR=rdevlin.cronin@chromium.org,kalman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474718, 475536 Committed: https://crrev.com/60a2857d182a7d980a7d43c9213cc1d96bf25f9e Cr-Commit-Position: refs/heads/master@{#325050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -258 lines) Patch
M chrome/browser/extensions/events_apitest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/extensions/api_test/events_are_unregistered/manifest.json View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/api_test/events_are_unregistered/page1.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/events_are_unregistered/page1.js View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/extensions/api_test/events_are_unregistered/page2.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/events_are_unregistered/page2.js View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/event_bindings.h View 4 chunks +6 lines, -27 lines 0 comments Download
M extensions/renderer/event_bindings.cc View 6 chunks +20 lines, -43 lines 0 comments Download
M extensions/renderer/event_unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M extensions/renderer/module_system.h View 3 chunks +0 lines, -13 lines 0 comments Download
M extensions/renderer/module_system.cc View 5 chunks +10 lines, -18 lines 0 comments Download
M extensions/renderer/module_system_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/native_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/native_handler.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/resources/event.js View 5 chunks +16 lines, -0 lines 0 comments Download
M extensions/renderer/script_context.h View 4 chunks +5 lines, -17 lines 0 comments Download
M extensions/renderer/script_context.cc View 3 chunks +7 lines, -25 lines 0 comments Download
M extensions/renderer/script_context_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mlamouri (slow - plz ping)
Created Revert of Move the event attach/detach logic on unload from event.js to
5 years, 8 months ago (2015-04-14 10:21:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083663004/1
5 years, 8 months ago (2015-04-14 10:22:00 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/events_apitest.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-14 10:22:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083663004/1
5 years, 8 months ago (2015-04-14 15:21:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 15:22:52 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 15:23:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60a2857d182a7d980a7d43c9213cc1d96bf25f9e
Cr-Commit-Position: refs/heads/master@{#325050}

Powered by Google App Engine
This is Rietveld 408576698