Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: lib/isolate_runner.dart

Issue 1083653002: Update package:isolate to make kill priority named. (Closed) Base URL: https://github.com/dart-lang/isolate.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/isolate_runner.dart
diff --git a/lib/isolate_runner.dart b/lib/isolate_runner.dart
index 2d1809513f47737f4b0d3fc6213a3cdf037834d8..fbfe4d61a7e24c3396f6cb0dd43b83a8650410a6 100644
--- a/lib/isolate_runner.dart
+++ b/lib/isolate_runner.dart
@@ -101,13 +101,13 @@ class IsolateRunner implements Runner {
Future kill({Duration timeout: const Duration(seconds: 1)}) {
Future onExit = singleResponseFuture(isolate.addOnExitListener);
if (Duration.ZERO == timeout) {
- isolate.kill(Isolate.IMMEDIATE);
+ isolate.kill(priority: Isolate.IMMEDIATE);
return onExit;
} else {
// Try a more gentle shutdown sequence.
_commandPort.send(list1(_SHUTDOWN));
return onExit.timeout(timeout, onTimeout: () {
- isolate.kill(Isolate.IMMEDIATE);
+ isolate.kill(priority: Isolate.IMMEDIATE);
return onExit;
});
}
« no previous file with comments | « no previous file | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698