Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083543005: Remove use_allocator=none where it's implied. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove use_allocator=none where it's implied. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -60 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan_tester.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Tests__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_Tests__sandboxed_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_Chromium_OS_ASan_LSan_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_Chromium_OS_ASan_LSan_Tests__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_ASAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Oilpan_ASAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_Linux_ASAN_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_Linux_ASan_LSan_Tests__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_branches_Chromium_ASAN__symbolized_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_asan_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_asan_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_asan_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_asan_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/analyze_finds_invalid_target.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/analyze_for_non_src_project.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/base_unittests_failure_swarming.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_matching_exclusion.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_tests.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test_swarming.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/full_tryserver_chromium_linux_linux_chromium_asan_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/gclient_runhooks__with_patch__failure.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/no_compile_because_of_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/swarming_basic_cq.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/swarming_basic_try_job.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/swarming_missing_isolated.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_asan__parallel_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
Michael Achenbach
Preliminary CL. Attempting to clean up redundancy. common.gypi implies use_allocator=none for asan=1 in case of ...
5 years, 8 months ago (2015-04-16 12:00:25 UTC) #2
Michael Achenbach
FYI: https://chromium.googlesource.com/chromium/src/+/62b271de77990e9cb5c530c8a27ff41f21f9b1b3/build/common.gypi#2168
5 years, 8 months ago (2015-04-16 12:16:00 UTC) #3
kjellander_chromium
On 2015/04/16 12:00:25, Michael Achenbach wrote: > Preliminary CL. Attempting to clean up redundancy. common.gypi ...
5 years, 8 months ago (2015-04-16 12:35:58 UTC) #4
Michael Achenbach
I assume your lgtm is for libyuv and webrtc?
5 years, 8 months ago (2015-04-16 13:24:57 UTC) #5
kjellander_chromium
On 2015/04/16 13:24:57, Michael Achenbach wrote: > I assume your lgtm is for libyuv and ...
5 years, 8 months ago (2015-04-16 13:26:35 UTC) #6
Alexander Potapenko
LGTM
5 years, 8 months ago (2015-04-16 13:33:44 UTC) #7
Michael Achenbach
Guess which project didn't imply use_allocator=none? Hint: it starts with a v and ends with ...
5 years, 8 months ago (2015-04-16 13:35:25 UTC) #8
Michael Achenbach
+ Pawel for chromium
5 years, 8 months ago (2015-04-16 13:52:33 UTC) #10
Paweł Hajdan Jr.
LGTM
5 years, 8 months ago (2015-04-16 17:31:43 UTC) #11
commit-bot: I haz the power
COMMIT=false is deprecated please use the dry run button instead.
5 years, 8 months ago (2015-04-23 08:40:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083543005/1
5 years, 8 months ago (2015-04-23 08:42:36 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 08:49:03 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294959

Powered by Google App Engine
This is Rietveld 408576698