Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Side by Side Diff: chrome/browser/net/certificate_error_reporter.h

Issue 1083493003: Encrypt certificate reports before uploading to HTTP URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add aead files to BUILD.gn Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/net/cert_logger.proto ('k') | chrome/browser/net/certificate_error_reporter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_ 5 #ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
6 #define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_ 6 #define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "net/url_request/url_request.h" 13 #include "net/url_request/url_request.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 namespace net { 16 namespace net {
17 class URLRequestContext; 17 class URLRequestContext;
18 class SSLInfo; 18 class SSLInfo;
19 } 19 }
20 20
21 namespace chrome_browser_net { 21 namespace chrome_browser_net {
22 22
23 class CertLoggerRequest; 23 class CertLoggerRequest;
24 class EncryptedCertLoggerRequest;
24 25
25 // Provides functionality for sending reports about invalid SSL 26 // Provides functionality for sending reports about invalid SSL
26 // certificate chains to a report collection server. 27 // certificate chains to a report collection server.
27 class CertificateErrorReporter : public net::URLRequest::Delegate { 28 class CertificateErrorReporter : public net::URLRequest::Delegate {
28 public: 29 public:
29 // These represent the types of reports that can be sent. 30 // These represent the types of reports that can be sent.
30 enum ReportType { 31 enum ReportType {
31 // A report of a certificate chain that failed a certificate pinning 32 // A report of a certificate chain that failed a certificate pinning
32 // check. 33 // check.
33 REPORT_TYPE_PINNING_VIOLATION, 34 REPORT_TYPE_PINNING_VIOLATION,
34 // A report for an invalid certificate chain that is being sent for 35 // A report for an invalid certificate chain that is being sent for
35 // a user who has opted-in to the extended reporting program. 36 // a user who has opted-in to the extended reporting program.
36 REPORT_TYPE_EXTENDED_REPORTING 37 REPORT_TYPE_EXTENDED_REPORTING
37 }; 38 };
38 39
39 // Represents whether or not to send cookies along with reports sent 40 // Represents whether or not to send cookies along with reports sent
40 // to the server. 41 // to the server.
41 enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES }; 42 enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES };
42 43
43 // Create a certificate error reporter that will send certificate 44 // Create a certificate error reporter that will send certificate
44 // error reports to |upload_url|, using |request_context| as the 45 // error reports to |upload_url|, using |request_context| as the
45 // context for the reports. |cookies_preference| controls whether 46 // context for the reports. |cookies_preference| controls whether
46 // cookies will be sent along with the reports. 47 // cookies will be sent along with the reports.
47 CertificateErrorReporter(net::URLRequestContext* request_context, 48 CertificateErrorReporter(net::URLRequestContext* request_context,
48 const GURL& upload_url, 49 const GURL& upload_url,
49 CookiesPreference cookies_preference); 50 CookiesPreference cookies_preference);
50 51
52 // Allows tests to use a server public key with known private key.
53 CertificateErrorReporter(net::URLRequestContext* request_context,
54 const GURL& upload_url,
55 CookiesPreference cookies_preference,
56 const uint8 server_public_key[32],
57 const uint32 server_public_key_version);
58
51 ~CertificateErrorReporter() override; 59 ~CertificateErrorReporter() override;
52 60
53 // Construct, serialize, and send a certificate report to the report 61 // Construct, serialize, and send a certificate report to the report
54 // collection server containing the |ssl_info| associated with a 62 // collection server containing the |ssl_info| associated with a
55 // connection to |hostname|. 63 // connection to |hostname|.
56 // 64 //
57 // SendReport actually sends the report over the network; callers are 65 // SendReport actually sends the report over the network; callers are
58 // responsible for enforcing any preconditions (such as obtaining user 66 // responsible for enforcing any preconditions (such as obtaining user
59 // opt-in, only sending reports for certain hostnames, checking for 67 // opt-in, only sending reports for certain hostnames, checking for
60 // incognito mode, etc.). 68 // incognito mode, etc.).
69 //
70 // On some platforms (but not all), CertificateErrorReporter can use
71 // an HTTP endpoint to send encrypted extended reporting reports. On
72 // unsupported platforms, callers must send extended reporting reports
73 // over SSL.
61 virtual void SendReport(ReportType type, 74 virtual void SendReport(ReportType type,
62 const std::string& hostname, 75 const std::string& hostname,
63 const net::SSLInfo& ssl_info); 76 const net::SSLInfo& ssl_info);
64 77
65 // net::URLRequest::Delegate 78 // net::URLRequest::Delegate
66 void OnResponseStarted(net::URLRequest* request) override; 79 void OnResponseStarted(net::URLRequest* request) override;
67 void OnReadCompleted(net::URLRequest* request, int bytes_read) override; 80 void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
68 81
82 // Callers can use this method to determine if sending reports over
83 // HTTP is supported.
84 static bool IsHttpUploadUrlSupported();
85
86 // Used by tests.
87 static bool DecryptCertificateErrorReport(
88 const uint8 server_private_key[32],
89 const EncryptedCertLoggerRequest& encrypted_report,
90 CertLoggerRequest* decrypted_report);
91
69 private: 92 private:
70 // Create a URLRequest with which to send a certificate report to the 93 // Create a URLRequest with which to send a certificate report to the
71 // server. 94 // server.
72 virtual scoped_ptr<net::URLRequest> CreateURLRequest( 95 virtual scoped_ptr<net::URLRequest> CreateURLRequest(
73 net::URLRequestContext* context); 96 net::URLRequestContext* context);
74 97
75 // Serialize and send a CertLoggerRequest protobuf to the report 98 // Serialize and send a CertLoggerRequest protobuf to the report
76 // collection server. 99 // collection server.
77 void SendCertLoggerRequest(const CertLoggerRequest& request); 100 void SendCertLoggerRequest(const CertLoggerRequest& request);
78 101
102 void SendSerializedRequest(const std::string& serialized_request);
103
79 // Populate the CertLoggerRequest for a report. 104 // Populate the CertLoggerRequest for a report.
80 static void BuildReport(const std::string& hostname, 105 static void BuildReport(const std::string& hostname,
81 const net::SSLInfo& ssl_info, 106 const net::SSLInfo& ssl_info,
82 CertLoggerRequest* out_request); 107 CertLoggerRequest* out_request);
83 108
84 // Performs post-report cleanup. 109 // Performs post-report cleanup.
85 void RequestComplete(net::URLRequest* request); 110 void RequestComplete(net::URLRequest* request);
86 111
87 net::URLRequestContext* const request_context_; 112 net::URLRequestContext* const request_context_;
88 const GURL upload_url_; 113 const GURL upload_url_;
89 114
90 // Owns the contained requests. 115 // Owns the contained requests.
91 std::set<net::URLRequest*> inflight_requests_; 116 std::set<net::URLRequest*> inflight_requests_;
92 117
93 CookiesPreference cookies_preference_; 118 CookiesPreference cookies_preference_;
94 119
120 const uint8* server_public_key_;
121 const uint32 server_public_key_version_;
122
95 DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter); 123 DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
96 }; 124 };
97 125
98 } // namespace chrome_browser_net 126 } // namespace chrome_browser_net
99 127
100 #endif // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_ 128 #endif // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
OLDNEW
« no previous file with comments | « chrome/browser/net/cert_logger.proto ('k') | chrome/browser/net/certificate_error_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698