Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1083463003: Sync: Add Android test for downloading a bookmark (Closed)

Created:
5 years, 8 months ago by pval...(no longer on Chromium)
Modified:
5 years, 8 months ago
Reviewers:
nyquist, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync: Add Android test for downloading a bookmark This CL adds the FakeServer+Android infrastructure for injecting a bookmark. There is also some minor refactoring done in fake_server.cc to reduce code duplication. BUG=365774 Committed: https://crrev.com/9c052713563111ac3d6cc64d4b5cfdfa27c202f4 Cr-Commit-Position: refs/heads/master@{#325299}

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix exit-time destructors #

Patch Set 4 : fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -43 lines) Patch
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java View 4 chunks +40 lines, -12 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java View 1 chunk +17 lines, -0 lines 0 comments Download
M sync/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.h View 2 chunks +15 lines, -0 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M sync/test/fake_server/bookmark_entity_builder.h View 2 chunks +7 lines, -0 lines 0 comments Download
M sync/test/fake_server/bookmark_entity_builder.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M sync/test/fake_server/fake_server.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M sync/test/fake_server/fake_server.cc View 1 2 6 chunks +39 lines, -23 lines 0 comments Download

Messages

Total messages: 44 (22 generated)
pval...(no longer on Chromium)
5 years, 8 months ago (2015-04-10 23:45:58 UTC) #4
Nicolas Zea
lgtm
5 years, 8 months ago (2015-04-13 18:26:12 UTC) #6
nyquist
lgtm
5 years, 8 months ago (2015-04-13 20:42:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/40001
5 years, 8 months ago (2015-04-13 22:11:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/65718) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 8 months ago (2015-04-13 22:24:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/60001
5 years, 8 months ago (2015-04-13 22:47:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/56925)
5 years, 8 months ago (2015-04-13 22:58:05 UTC) #16
pval...(no longer on Chromium)
@zea PTAL: fixed exit-time destructor issue
5 years, 8 months ago (2015-04-14 18:25:16 UTC) #17
Nicolas Zea
lgtm
5 years, 8 months ago (2015-04-14 18:34:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/80001
5 years, 8 months ago (2015-04-14 19:12:02 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/78088)
5 years, 8 months ago (2015-04-14 19:35:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/100001
5 years, 8 months ago (2015-04-14 20:40:41 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48091)
5 years, 8 months ago (2015-04-14 23:10:36 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/100001
5 years, 8 months ago (2015-04-14 23:21:40 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48150)
5 years, 8 months ago (2015-04-15 00:58:26 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/100001
5 years, 8 months ago (2015-04-15 01:25:24 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48200)
5 years, 8 months ago (2015-04-15 02:59:15 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/100001
5 years, 8 months ago (2015-04-15 18:16:42 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48449)
5 years, 8 months ago (2015-04-15 19:51:25 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083463003/100001
5 years, 8 months ago (2015-04-15 20:50:55 UTC) #42
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 8 months ago (2015-04-15 20:53:12 UTC) #43
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:54:41 UTC) #44
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9c052713563111ac3d6cc64d4b5cfdfa27c202f4
Cr-Commit-Position: refs/heads/master@{#325299}

Powered by Google App Engine
This is Rietveld 408576698