printing/printing_context_system_dialog_win.cc - Issue 1083433003: Fix crash from ipc_fuzzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_system_dialog_win.cc

Issue 1083433003: Fix crash from ipc_fuzzer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fri Apr 10 16:31:41 PDT 2015 Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/printing_context_system_dialog_win.cc

diff --git a/printing/printing_context_system_dialog_win.cc b/printing/printing_context_system_dialog_win.cc

index e67ae3bf839f003d036e24e8b7b58097b30868ff..f11e0686df34d9d4e95e474e980279a5992c3361 100644

--- a/printing/printing_context_system_dialog_win.cc

+++ b/printing/printing_context_system_dialog_win.cc

@@ -68,7 +68,7 @@ void PrintingContextSytemDialogWin::AskUserForSettings(

if (ShowPrintDialog(&dialog_options) != S_OK) {

ResetSettings();

- callback.Run(FAILED);

+ return callback.Run(FAILED);

Aleksey Shlyapnikov 2015/04/10 23:55:31 Looks weird to return like this from void function

Vitaly Buka (NO REVIEWS) 2015/04/11 00:23:05 Done.

}

// TODO(maruel): Support PD_PRINTTOFILE.

« no previous file with comments | « printing/printing_context_system_dialog_win.h ('k') | printing/printing_context_win.h » ('j') | no next file with comments »