Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1083433003: Fix crash from ipc_fuzzer (Closed)

Created:
5 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash from ipc_fuzzer Can't reproduce original crash so I just fix all crashes I see. Use WeakPtr in AskUserForSettings callback. Move chrome::ShowMessageBox in separate task and protection against nested message boxes. Add missing return into AskUserForSettings. BUG=472146 Committed: https://crrev.com/442258da866dda0b7ddcb35c51b9591e17c0de8c Cr-Commit-Position: refs/heads/master@{#324746}

Patch Set 1 #

Patch Set 2 : Fri Apr 10 16:31:41 PDT 2015 #

Total comments: 2

Patch Set 3 : Fri Apr 10 17:21:19 PDT 2015 #

Patch Set 4 : Fri Apr 10 17:22:28 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M chrome/browser/printing/print_job_worker.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 1 2 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M printing/printing_context_system_dialog_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/1083433003/diff/20001/printing/printing_context_system_dialog_win.cc File printing/printing_context_system_dialog_win.cc (right): https://codereview.chromium.org/1083433003/diff/20001/printing/printing_context_system_dialog_win.cc#newcode71 printing/printing_context_system_dialog_win.cc:71: return callback.Run(FAILED); Looks weird to return like this ...
5 years, 8 months ago (2015-04-10 23:55:31 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1083433003/diff/20001/printing/printing_context_system_dialog_win.cc File printing/printing_context_system_dialog_win.cc (right): https://codereview.chromium.org/1083433003/diff/20001/printing/printing_context_system_dialog_win.cc#newcode71 printing/printing_context_system_dialog_win.cc:71: return callback.Run(FAILED); On 2015/04/10 23:55:31, Aleksey Shlyapnikov wrote: > ...
5 years, 8 months ago (2015-04-11 00:23:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083433003/60001
5 years, 8 months ago (2015-04-11 00:24:48 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-11 01:46:55 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 01:48:35 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/442258da866dda0b7ddcb35c51b9591e17c0de8c
Cr-Commit-Position: refs/heads/master@{#324746}

Powered by Google App Engine
This is Rietveld 408576698