More gracefully handle load errors.

test/runner/pub_serve_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn("vm")
 
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:path/path.dart' as p;
@@ skipping 118 matching lines @@
               workingDirectory: _sandbox)
           .then((process) {
         return _lines.bind(process.stdout)
             .firstWhere(_servingRegExp.hasMatch)
             .then((line) {
           var match = _servingRegExp.firstMatch(line);
 
           try {
             var result = runUnittest(['--pub-serve=${match[1]}'],
                 workingDirectory: _sandbox);
-            expect(result.stderr, contains(
-                'Failed to load "test/my_test.dart":'));
-            expect(result.stderr, contains('404 Not Found'));
-            expect(result.stderr, contains(
-                'Make sure "pub serve" is serving the test/ directory.'));
-            expect(result.exitCode, equals(exit_codes.data));
+            expect(result.stdout, allOf([
+              contains('-1: load error'),
+              contains('Failed to load "test/my_test.dart":'),
+              contains('404 Not Found'),
+              contains('Make sure "pub serve" is serving the test/ directory.')
+            ]));
+            expect(result.exitCode, equals(1));
           } finally {
             process.kill();
           }
         });
       });
     });
 
     test("gracefully handles pub serve running on the wrong directory for "
         "browser tests", () {
       new Directory(p.join(_sandbox, "web")).createSync();
 
       return startPub(['serve', '--port', '0', 'web'],
               workingDirectory: _sandbox)
           .then((process) {
         return _lines.bind(process.stdout)
             .firstWhere(_servingRegExp.hasMatch)
             .then((line) {
           var match = _servingRegExp.firstMatch(line);
 
           try {
             var result = runUnittest(
                 ['--pub-serve=${match[1]}', '-p', 'chrome'],
                 workingDirectory: _sandbox);
-            expect(result.stderr, contains(
-                'Failed to load "test/my_test.dart":'));
-            expect(result.stderr, contains('404 Not Found'));
-            expect(result.stderr, contains(
-                'Make sure "pub serve" is serving the test/ directory.'));
-            expect(result.exitCode, equals(exit_codes.data));
+            expect(result.stdout, allOf([
+              contains('-1: load error'),
+              contains('Failed to load "test/my_test.dart":'),
+              contains('404 Not Found'),
+              contains('Make sure "pub serve" is serving the test/ directory.')
+            ]));
+            expect(result.exitCode, equals(1));
           } finally {
             process.kill();
           }
         });
       });
     });
 
     test("gracefully handles unconfigured transformers", () {
       new File(p.join(_sandbox, "pubspec.yaml")).writeAsStringSync("""
 name: myapp
@@ skipping 26 matching lines @@
             process.kill();
           }
         });
       });
     });
   });
 
   test("gracefully handles pub serve not running for VM tests", () {
     var result = runUnittest(['--pub-serve=54321'],
         workingDirectory: _sandbox);
-    expect(result.stderr, equals('''
-Failed to load "test/my_test.dart":
-Error getting http://localhost:54321/my_test.vm_test.dart: Connection refused
-Make sure "pub serve" is running.
-'''));
-    expect(result.exitCode, equals(exit_codes.data));
+    expect(result.stdout, allOf([
+      contains('-1: load error'),
+      contains('''
+  Failed to load "test/my_test.dart":
+  Error getting http://localhost:54321/my_test.vm_test.dart: Connection refused
+  Make sure "pub serve" is running.''')
+    ]));
+    expect(result.exitCode, equals(1));
   });
 
   test("gracefully handles pub serve not running for browser tests", () {
     var result = runUnittest(['--pub-serve=54321', '-p', 'chrome'],
         workingDirectory: _sandbox);
-    expect(result.stderr, matches(r'''
-Failed to load "test/my_test\.dart":
-Error getting http://localhost:54321/my_test\.browser_test.dart\.js: Connection refused \(errno \d+\)
-Make sure "pub serve" is running\.
-'''));
-    expect(result.exitCode, equals(exit_codes.data));
+    expect(result.stdout, allOf([
+      contains('-1: load error'),
+      contains('Failed to load "test/my_test.dart":'),
+      contains('Error getting http://localhost:54321/my_test.browser_test.dart'
+          '.js: Connection refused (errno '),
+      contains('Make sure "pub serve" is running.')
+    ]));
+    expect(result.exitCode, equals(1));
   });
 
   test("gracefully handles a test file not being in test/", () {
     new File(p.join(_sandbox, 'test/my_test.dart'))
         .copySync(p.join(_sandbox, 'my_test.dart'));
 
     var result = runUnittest(['--pub-serve=54321', 'my_test.dart'],
         workingDirectory: _sandbox);
-    expect(result.stderr, equals(
-        'Failed to load "my_test.dart": When using "pub serve", all test files '
-            'must be in test/.\n'));
+    expect(result.stdout, allOf([
+      contains('-1: load error'),
+      contains(
+          'Failed to load "my_test.dart": When using "pub serve", all test '
+              'files must be in test/.\n')
+    ]));
+    expect(result.exitCode, equals(1));
   });
 }