More gracefully handle load errors.

lib/src/executable.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(nweiz): This is under lib so that it can be used by the unittest dummy
 // package. Once that package is no longer being updated, move this back into
 // bin.
 library test.executable;
 
 import 'dart:async';
 import 'dart:io';
-import 'dart:isolate';
 import 'dart:math' as math;
 
 import 'package:args/args.dart';
 import 'package:stack_trace/stack_trace.dart';
 import 'package:yaml/yaml.dart';
 
 import 'backend/test_platform.dart';
 import 'runner/reporter/compact.dart';
 import 'runner/load_exception.dart';
+import 'runner/load_exception_suite.dart';
 import 'runner/loader.dart';
 import 'util/exit_codes.dart' as exit_codes;
 import 'util/io.dart';
 import 'utils.dart';
 
 /// The argument parser used to parse the executable arguments.
 final _parser = new ArgParser(allowTrailingOptions: true);
 
 /// The default number of test suites to run at once.
 ///
@@ skipping 112 matching lines @@
     try {
       concurrency = int.parse(options["concurrency"]);
     } catch (error) {
       _printUsage('Couldn\'t parse --concurrency "${options["concurrency"]}":'
           ' ${error.message}');
       exitCode = exit_codes.usage;
       return;
     }
   }
 
+  var paths = options.rest;
+  if (paths.isEmpty) {
+    if (!new Directory("test").existsSync()) {
+      _printUsage('No test files were passed and the default "test/" '
+          "directory doesn't exist.");
+      exitCode = exit_codes.data;
+      return;
+    }
+    paths = ["test"];
+  }
+
   var signalSubscription;
   var closed = false;
   signalSubscription = _signals.listen((_) {
     signalSubscription.cancel();
     closed = true;
     loader.close();
   });
 
-  new Future.sync(() {
-    var paths = options.rest;
-    if (paths.isEmpty) {
-      if (!new Directory("test").existsSync()) {
-        throw new LoadException("test",
-            "No test files were passed and the default directory doesn't "
-                "exist.");
-      }
-      paths = ["test"];
+  mergeStreams(paths.map((path) {
+    if (new Directory(path).existsSync()) return loader.loadDir(path);
+    if (new File(path).existsSync()) return loader.loadFile(path);
+    return new Stream.fromFuture(new Future.error(
+        new LoadException(path, 'Does not exist.'),
+        new Trace.current()));
+  })).transform(new StreamTransformer.fromHandlers(
+      handleError: (error, stackTrace, sink) {
+    if (error is! LoadException) {
+      sink.addError(error, stackTrace);
+    } else {
+      sink.add(new LoadExceptionSuite(error));
     }
-
-    return Future.wait(paths.map((path) {
-      if (new Directory(path).existsSync()) return loader.loadDir(path);
-      if (new File(path).existsSync()) return loader.loadFile(path);
-      throw new LoadException(path, 'Does not exist.');
-    }));
-  }).then((suites) {
+  })).toList().then((suites) {
     if (closed) return null;
     suites = flatten(suites);
 
     var pattern;
     if (options["name"] != null) {
       if (options["plain-name"] != null) {
         _printUsage("--name and --plain-name may not both be passed.");
         exitCode = exit_codes.data;
         return null;
       }
       pattern = new RegExp(options["name"]);
     } else if (options["plain-name"] != null) {
       pattern = options["plain-name"];
     }
 
     if (pattern != null) {
       suites = suites.map((suite) {
+        // Don't ever filter out load errors.
+        if (suite is LoadExceptionSuite) return suite;
         return suite.change(
             tests: suite.tests.where((test) => test.name.contains(pattern)));
       }).toList();
 
       if (suites.every((suite) => suite.tests.isEmpty)) {
         stderr.write('No tests match ');
 
         if (pattern is RegExp) {
-          stderr.write('regular expression "${pattern.pattern}".');
+          stderr.writeln('regular expression "${pattern.pattern}".');
         } else {
           stderr.writeln('"$pattern".');
         }
         exitCode = exit_codes.data;
         return null;
       }
     }
 
     var reporter = new CompactReporter(flatten(suites),
         concurrency: concurrency, color: color);
@@ skipping 17 matching lines @@
       reporter.close().then((_) => timer.cancel());
     });
 
     return reporter.run().then((success) {
       exitCode = success ? 0 : 1;
     }).whenComplete(() {
       signalSubscription.cancel();
       return reporter.close();
     });
   }).whenComplete(signalSubscription.cancel).catchError((error, stackTrace) {
-    if (error is LoadException) {
-      stderr.writeln(error.toString(color: color));
-
-      // Only print stack traces for load errors that come from the user's 
-      if (error.innerError is! IOException &&
-          error.innerError is! IsolateSpawnException &&
-          error.innerError is! FormatException &&
-          error.innerError is! String) {
-        stderr.write(terseChain(stackTrace));
-      }
-
-      exitCode = error.innerError is IOException
-          ? exit_codes.io
-          : exit_codes.data;
-    } else {
-      stderr.writeln(getErrorMessage(error));
-      stderr.writeln(new Trace.from(stackTrace).terse);
-      stderr.writeln(
-          "This is an unexpected error. Please file an issue at "
-              "http://github.com/dart-lang/test\n"
-          "with the stack trace and instructions for reproducing the error.");
-      exitCode = exit_codes.software;
-    }
+    stderr.writeln(getErrorMessage(error));
+    stderr.writeln(new Trace.from(stackTrace).terse);
+    stderr.writeln(
+        "This is an unexpected error. Please file an issue at "
+            "http://github.com/dart-lang/test\n"
+        "with the stack trace and instructions for reproducing the error.");
+    exitCode = exit_codes.software;
   }).whenComplete(() {
     return loader.close().then((_) {
       // If we're on a Dart version that doesn't support Isolate.kill(), we have
       // to manually exit so that dangling isolates don't prevent it.
       if (!supportsIsolateKill) exit(exitCode);
     });
   });
 }
 
 /// Print usage information for this command.
 ///
 /// If [error] is passed, it's used in place of the usage message and the whole
 /// thing is printed to stderr instead of stdout.
 void _printUsage([String error]) {
   var output = stdout;
 
   var message = "Runs tests in this package.";
   if (error != null) {
     message = error;
     output = stderr;
   }
 
   output.write("""$message
 
 Usage: pub run test:test [files or directories...]
 
 ${_parser.usage}
 """);
 }