Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 108343009: [SyncFS] Move FakeDriveServiceHelper from V1 directory to V2. (Closed)

Created:
6 years, 11 months ago by tzik
Modified:
6 years, 11 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Move FakeDriveServiceHelper from V1 directory to V2. BUG=331991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243752

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -412 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_sync_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync_file_system/drive_backend_v1/fake_drive_service_helper.h View 1 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/sync_file_system/drive_backend_v1/fake_drive_service_helper.cc View 1 1 chunk +0 lines, -306 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/fake_drive_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
PTL.
6 years, 11 months ago (2014-01-07 05:28:16 UTC) #1
nhiroki
lgtm
6 years, 11 months ago (2014-01-07 05:31:45 UTC) #2
kinuko
https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc File chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc (right): https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc#newcode167 chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc:167: APIUtil::GetSyncRootDirectoryName(), std::string(), Can you make this not rely on ...
6 years, 11 months ago (2014-01-07 05:45:50 UTC) #3
tzik
https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc File chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc (right): https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc#newcode167 chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc:167: APIUtil::GetSyncRootDirectoryName(), std::string(), On 2014/01/07 05:45:51, kinuko wrote: > Can ...
6 years, 11 months ago (2014-01-07 06:38:16 UTC) #4
tzik
PTAL? https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc File chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc (right): https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc#newcode167 chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc:167: APIUtil::GetSyncRootDirectoryName(), std::string(), On 2014/01/07 06:38:18, tzik wrote: > ...
6 years, 11 months ago (2014-01-08 14:43:01 UTC) #5
kinuko
On 2014/01/08 14:43:01, tzik wrote: > PTAL? > > https://codereview.chromium.org/108343009/diff/1/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc > File chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc > (right): ...
6 years, 11 months ago (2014-01-08 23:50:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/108343009/120001
6 years, 11 months ago (2014-01-09 01:39:46 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 04:04:07 UTC) #8
Message was sent while issue was closed.
Change committed as 243752

Powered by Google App Engine
This is Rietveld 408576698