Issue 108343008: Move traverseLiveNodeListFirstElement() to LiveNodeList class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108343008: Move traverseLiveNodeListFirstElement() to LiveNodeList class (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
eseidel, abarth-chromium

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move traverseLiveNodeListFirstElement() to LiveNodeList class Move traverseLiveNodeListFirstElement() to LiveNodeList class and rename to traverseToFirstElement() for consistency with HTMLCollection::traverseToFirstElement(). Also handle ChildNodeList in LiveNodeList::traverseToFirstElement() as ChildNodeList is a LiveNodeList and there is no reason to treat it differently from the other LiveNodeList subclasses. R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164802

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -17 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	6 chunks	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Inactive

On 2014/01/05 20:47:50, Chris Dumez wrote: This is a follow-up to https://codereview.chromium.org/120593002/

6 years, 11 months ago (2014-01-07 20:40:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/108343008/1

6 years, 11 months ago (2014-01-09 18:50:31 UTC) #5

Message was sent while issue was closed.

Change committed as 164802

Expand Messages | Collapse Messages