Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 108343005: Revert 240542 "Make sure the dragged window is smaller than work..." (Closed)

Created:
7 years ago by hashimoto
Modified:
7 years ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 240542 "Make sure the dragged window is smaller than work..." Faling in ash_unittests DragWindowResizerTest.WindowDragWithMultiDisplays: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37164 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/27462 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29/builds/14494 > Make sure the dragged window is smaller than work area in the target display. > > - makes sure that minimum amount of window is visible when dropped. > > - When moving a window to another due to display disconnect, try to keep relative position in the work are, rather than absolute position to the root window. > > BUG=321702 > TEST=covered by test > RootWindowController::MoveWindows_Basic > DragWindowResizerTest::WindowDragWithMultiDisplays > > Review URL: https://codereview.chromium.org/93873013 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -134 lines) Patch
M trunk/src/ash/root_window_controller.cc View 2 chunks +1 line, -33 lines 0 comments Download
M trunk/src/ash/root_window_controller_unittest.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M trunk/src/ash/wm/drag_window_resizer.cc View 1 chunk +3 lines, -23 lines 0 comments Download
M trunk/src/ash/wm/drag_window_resizer_unittest.cc View 2 chunks +1 line, -50 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
7 years ago (2013-12-13 11:19:23 UTC) #1
hashimoto
Committed patchset #1 manually as r240587.
7 years ago (2013-12-13 11:19:35 UTC) #2
oshima
7 years ago (2013-12-13 20:17:54 UTC) #3
Ugh , there seems to be a conflicting change landed before my cl lands.
Thank you for taking care of it.


On Fri, Dec 13, 2013 at 3:19 AM, <hashimoto@chromium.org> wrote:

> Committed patchset #1 manually as r240587.
>
> https://codereview.chromium.org/108343005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698