Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1083413010: Fix GN build for junit tests (Closed)

Created:
5 years, 8 months ago by dgn
Modified:
5 years, 8 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN build for junit tests A dex path was required for all build types while for unit tests (java_library) we don't provide one. BUG=480445 Committed: https://crrev.com/d88c889bc2b6632810d7eb6f73ae8b4cf851168f Cr-Commit-Position: refs/heads/master@{#326665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/gyp/write_build_config.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgn
PTAL
5 years, 8 months ago (2015-04-23 16:47:43 UTC) #2
cjhopman
lgtm
5 years, 8 months ago (2015-04-23 17:51:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083413010/1
5 years, 8 months ago (2015-04-23 20:52:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 22:05:51 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:06:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d88c889bc2b6632810d7eb6f73ae8b4cf851168f
Cr-Commit-Position: refs/heads/master@{#326665}

Powered by Google App Engine
This is Rietveld 408576698