Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: chrome/browser/ui/webui/feedback_ui.cc

Issue 10834107: chrome: Refactor the way to show the feedback ui and move it into chrome namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/feedback_ui.cc
diff --git a/chrome/browser/ui/webui/feedback_ui.cc b/chrome/browser/ui/webui/feedback_ui.cc
index 9ebee7001b46b337030d2f46f2dc2a9808ac6714..1e75e5491c74ef1e528debcc53fdbc592cbc9129 100644
--- a/chrome/browser/ui/webui/feedback_ui.cc
+++ b/chrome/browser/ui/webui/feedback_ui.cc
@@ -31,6 +31,7 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/browser/ui/tab_contents/tab_contents.h"
+#include "chrome/browser/ui/web_feedback_ui.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
#include "chrome/browser/ui/webui/screenshot_source.h"
@@ -147,12 +148,11 @@ int GetIndexOfFeedbackTab(Browser* browser) {
} // namespace
+namespace chrome {
-namespace browser {
-
-void ShowWebFeedbackView(Browser* browser,
- const std::string& description_template,
- const std::string& category_tag) {
+void ShowFeedbackUI(Browser* browser,
+ const std::string& description_template,
+ const std::string& category_tag) {
#if defined(OS_CHROMEOS)
// Grab the timestamp before we do anything else - this is crucial to help
// diagnose some hardware issues.
@@ -206,7 +206,7 @@ void ShowWebFeedbackView(Browser* browser,
chrome::ShowSingletonTab(browser, GURL(feedback_url));
}
-} // namespace browser
+} // namespace chrome
// The handler for Javascript messages related to the "bug report" dialog
class FeedbackHandler : public WebUIMessageHandler,

Powered by Google App Engine
This is Rietveld 408576698