chrome/browser/ui/browser_commands.cc - Issue 10834107: chrome: Refactor the way to show the feedback ui and move it into chrome namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 10834107: chrome: Refactor the way to show the feedback ui and move it into chrome namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index bea0df9603bbc040240c2888c72b9176f38d0ab5..35262d66d8fa814636f14add3301baef876e8709 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -49,7 +49,7 @@

#include "chrome/browser/ui/status_bubble.h"

#include "chrome/browser/ui/tab_contents/tab_contents.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

-#include "chrome/browser/ui/webui/feedback_ui.h"

+#include "chrome/browser/ui/web_feedback_ui.h"

#include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"

#include "chrome/browser/web_applications/web_app.h"

#include "chrome/common/chrome_switches.h"

@@ -838,7 +838,7 @@ void OpenTaskManager(Browser* browser, bool highlight_background_resources) {

void OpenFeedbackDialog(Browser* browser) {

content::RecordAction(UserMetricsAction("Feedback"));

- browser::ShowWebFeedbackView(browser, std::string(), std::string());

+ chrome::ShowFeedbackUI(browser, std::string(), std::string());

}

void ToggleBookmarkBar(Browser* browser) {

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/web_feedback_ui.h » ('J')