Issue 10834107: chrome: Refactor the way to show the feedback ui and move it into chrome namespace.

Issue 10834107: chrome: Refactor the way to show the feedback ui and move it into chrome namespace. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, Ilya Sherman, dyu1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome: Refactor the way to show the feedback ui and move it into chrome namespace. BUG=133088 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149624

Patch Set 2 : chrome_pages #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
M	chrome/browser/autofill/autofill_feedback_infobar_delegate.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/chrome_pages.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/feedback_ui.h	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/feedback_ui.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/10834107/diff/1/chrome/browser/ui/web_feedback_ui.h File chrome/browser/ui/web_feedback_ui.h (right): http://codereview.chromium.org/10834107/diff/1/chrome/browser/ui/web_feedback_ui.h#newcode16 chrome/browser/ui/web_feedback_ui.h:16: const std::string& category_tag); Maybe this can go into ...

8 years, 4 months ago (2012-08-01 15:20:22 UTC) #2

tfarina

On Wed, Aug 1, 2012 at 12:20 PM, <ben@chromium.org> wrote: > lgtm > > > ...

8 years, 4 months ago (2012-08-01 15:23:19 UTC) #3

tfarina

On 2012/08/01 15:20:22, Ben Goodger (Google) wrote: > lgtm > > http://codereview.chromium.org/10834107/diff/1/chrome/browser/ui/web_feedback_ui.h > File chrome/browser/ui/web_feedback_ui.h ...

8 years, 4 months ago (2012-08-01 15:37:37 UTC) #4

lgtm

Expand Messages | Collapse Messages