Issue 10834063: Fix build with disassembler=on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834063: Fix build with disassembler=on (Closed)

Created:
8 years, 4 months ago by Zheng Liu

Modified:
8 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

R=jkummerow@chromium.org Fixed build with disassembler=on

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Thanks for reporting this, and for suggesting a fix. However, I'd prefer to keep OBJECT_PRINT ...

8 years, 4 months ago (2012-07-30 12:03:05 UTC) #2

Zheng Liu

8 years, 4 months ago (2012-07-30 12:12:14 UTC) #3

On 2012/07/30 12:03:05, Jakob wrote:
> Thanks for reporting this, and for suggesting a fix. However, I'd prefer to
keep
> OBJECT_PRINT and ENABLE_DISASSEMBLER separate for now. mstarzinger@ is working
> on a proper fix.

I see, thanks.

Expand Messages | Collapse Messages