Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: Source/core/layout/LayoutBlock.cpp

Issue 1083403005: Don't add duplicated line box rects into focus ring rects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase again Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/focus-ring-recursive-inlines-expected.txt ('k') | Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutBlock.cpp
diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp
index 0a7b15c3386cf2a35d3001843b9cbf0154b30dbe..6aa189fc9eb98f54b55729fc7bac7f14d579b22c 100644
--- a/Source/core/layout/LayoutBlock.cpp
+++ b/Source/core/layout/LayoutBlock.cpp
@@ -3547,8 +3547,12 @@ void LayoutBlock::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPoint
addChildFocusRingRects(rects, additionalOffset);
}
- if (inlineElementContinuation)
- inlineElementContinuation->addFocusRingRects(rects, additionalOffset + (inlineElementContinuation->containingBlock()->location() - location()));
+ if (inlineElementContinuation) {
+ Vector<LayoutRect> inlineFocusRingRects;
+ // We need to give the LayoutInline a clean vector to let it add focus ring rects of line boxes.
+ inlineElementContinuation->addFocusRingRects(inlineFocusRingRects, additionalOffset + (inlineElementContinuation->containingBlock()->location() - location()));
+ rects.appendVector(inlineFocusRingRects);
+ }
}
void LayoutBlock::computeSelfHitTestRects(Vector<LayoutRect>& rects, const LayoutPoint& layerOffset) const
« no previous file with comments | « LayoutTests/fast/css/focus-ring-recursive-inlines-expected.txt ('k') | Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698