Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 1083403005: Don't add duplicated line box rects into focus ring rects (Closed)

Created:
5 years, 8 months ago by Xianzhu
Modified:
5 years, 7 months ago
Reviewers:
dsinclair, pdr.
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't add duplicated line box rects into focus ring rects LayoutBlock::addFocusRingRects() adds root line box rects; LayoutInline::addFocusRingRects() adds its line box rects, but this is unnecessary if the parent has added root line box rects or normal line box rects. This might be the reason of OOM during addFocusRingRects. BUG=440700 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194562

Patch Set 1 #

Patch Set 2 : Test #

Patch Set 3 : Fix layout test #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
A LayoutTests/fast/css/focus-ring-recursive-inlines.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/focus-ring-recursive-inlines-expected.txt View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 3 1 chunk +11 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Xianzhu
5 years, 8 months ago (2015-04-24 21:31:38 UTC) #2
Xianzhu
Please hold off on review. There are some test breaks.
5 years, 8 months ago (2015-04-24 22:29:54 UTC) #3
Xianzhu
On 2015/04/24 22:29:54, Xianzhu wrote: > Please hold off on review. There are some test ...
5 years, 8 months ago (2015-04-24 22:39:21 UTC) #4
Xianzhu
On 2015/04/24 22:39:21, Xianzhu wrote: > On 2015/04/24 22:29:54, Xianzhu wrote: > > Please hold ...
5 years, 7 months ago (2015-04-27 23:51:03 UTC) #5
pdr.
lgtm LGTM
5 years, 7 months ago (2015-04-28 00:22:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083403005/40001
5 years, 7 months ago (2015-04-28 00:22:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43204) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 7 months ago (2015-04-28 00:25:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083403005/60001
5 years, 7 months ago (2015-04-28 00:49:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43207)
5 years, 7 months ago (2015-04-28 00:57:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083403005/80001
5 years, 7 months ago (2015-04-28 01:10:31 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 02:55:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194562

Powered by Google App Engine
This is Rietveld 408576698