Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083403002: [Android] Remove android_commands uses from build/android/. (reland) (Closed)

Created:
5 years, 8 months ago by jbudorick
Modified:
5 years, 8 months ago
Reviewers:
klundberg, perezju
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove android_commands uses from build/android/. (reland) original CL: https://codereview.chromium.org/1088793002/ BUG=267773 Committed: https://crrev.com/bfffb22e47e9c20bc2a7019d47f7e986a63f42f5 Cr-Commit-Position: refs/heads/master@{#325439}

Patch Set 1 : original #

Patch Set 2 : fixed #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -59 lines) Patch
M build/android/adb_install_apk.py View 2 chunks +5 lines, -3 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 2 chunks +9 lines, -5 lines 0 comments Download
M build/android/enable_asserts.py View 1 chunk +23 lines, -19 lines 0 comments Download
M build/android/host_heartbeat.py View 2 chunks +7 lines, -5 lines 0 comments Download
M build/android/provision_devices.py View 3 chunks +6 lines, -3 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 3 chunks +26 lines, -5 lines 2 comments Download
M build/android/pylib/device/adb_wrapper_test.py View 1 chunk +1 line, -1 line 0 comments Download
A build/android/pylib/device/device_filter.py View 1 chunk +53 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 2 chunks +8 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 2 chunks +3 lines, -2 lines 0 comments Download
M build/android/screenshot.py View 2 chunks +4 lines, -2 lines 0 comments Download
M build/android/tombstones.py View 2 chunks +6 lines, -4 lines 0 comments Download
M build/android/update_verification.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
5 years, 8 months ago (2015-04-15 18:35:40 UTC) #2
perezju
lgtm w/optional nit https://codereview.chromium.org/1083403002/diff/20001/build/android/pylib/device/adb_wrapper.py File build/android/pylib/device/adb_wrapper.py (right): https://codereview.chromium.org/1083403002/diff/20001/build/android/pylib/device/adb_wrapper.py#newcode197 build/android/pylib/device/adb_wrapper.py:197: return [d for d in devices ...
5 years, 8 months ago (2015-04-16 08:57:55 UTC) #3
jbudorick
https://codereview.chromium.org/1083403002/diff/20001/build/android/pylib/device/adb_wrapper.py File build/android/pylib/device/adb_wrapper.py (right): https://codereview.chromium.org/1083403002/diff/20001/build/android/pylib/device/adb_wrapper.py#newcode197 build/android/pylib/device/adb_wrapper.py:197: return [d for d in devices if matches_all_filters(d)] On ...
5 years, 8 months ago (2015-04-16 13:53:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083403002/20001
5 years, 8 months ago (2015-04-16 13:53:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 14:10:09 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 14:11:02 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bfffb22e47e9c20bc2a7019d47f7e986a63f42f5
Cr-Commit-Position: refs/heads/master@{#325439}

Powered by Google App Engine
This is Rietveld 408576698