Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083383006: fix ClassTypeAlias extends (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M lib/runtime/dart/_internal.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/async.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/collection.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 chunks +12 lines, -9 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
it helps to include the superclass too ;-)
5 years, 8 months ago (2015-04-24 22:14:41 UTC) #2
vsm
lgtm - thanks! https://codereview.chromium.org/1083383006/diff/20001/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1083383006/diff/20001/lib/src/codegen/js_codegen.dart#newcode538 lib/src/codegen/js_codegen.dart:538: JS.Expression _classHeritage(node) { node could still ...
5 years, 8 months ago (2015-04-24 22:31:55 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1083383006/diff/20001/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1083383006/diff/20001/lib/src/codegen/js_codegen.dart#newcode538 lib/src/codegen/js_codegen.dart:538: JS.Expression _classHeritage(node) { On 2015/04/24 22:31:55, vsm wrote: > ...
5 years, 8 months ago (2015-04-24 23:06:14 UTC) #4
Jennifer Messerly
5 years, 8 months ago (2015-04-24 23:06:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5b0bc2819a9d9cf7888377998010da19f59a56d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698