Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: media/blink/video_frame_compositor.h

Issue 1083383005: Connect the new video rendering path to the compositor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vra
Patch Set: Update LoginCustomFlags histogram. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer_sink.h ('k') | media/blink/video_frame_compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/video_frame_compositor.h
diff --git a/media/blink/video_frame_compositor.h b/media/blink/video_frame_compositor.h
index 02b6077f9605ff25029cfb08da5adefc8c3808e6..2e8c2ccc0e8f05667ac69b72e93d8b022474d48b 100644
--- a/media/blink/video_frame_compositor.h
+++ b/media/blink/video_frame_compositor.h
@@ -9,6 +9,7 @@
#include "base/memory/ref_counted.h"
#include "base/single_thread_task_runner.h"
#include "base/synchronization/lock.h"
+#include "base/time/tick_clock.h"
#include "cc/layers/video_frame_provider.h"
#include "media/base/media_export.h"
#include "media/base/video_renderer_sink.h"
@@ -91,26 +92,52 @@ class MEDIA_EXPORT VideoFrameCompositor
void PaintFrameUsingOldRenderingPath(
const scoped_refptr<VideoFrame>& frame) override;
+ void set_tick_clock_for_testing(scoped_ptr<base::TickClock> tick_clock) {
+ tick_clock_ = tick_clock.Pass();
+ }
+
+ base::TimeDelta get_stale_frame_threshold_for_testing() const {
+ return stale_frame_threshold_;
+ }
+
+ void clear_current_frame_for_testing() { current_frame_ = nullptr; }
+
private:
- // Called on the compositor thread to start or stop rendering if rendering was
- // previously started or stopped before we had a |callback_|.
- void OnRendererStateUpdate();
+ // Called on the compositor thread in response to Start() or Stop() calls;
+ // must be used to change |rendering_| state.
+ void OnRendererStateUpdate(bool new_state);
+
+ // Handles setting of |current_frame_| and fires |natural_size_changed_cb_|
+ // and |opacity_changed_cb_| when the frame properties changes. Will also
+ // call DidReceiveFrame() on |client_| if |notify_client_of_new_frames| is
+ // true and a new frame is encountered.
+ bool ProcessNewFrame(const scoped_refptr<VideoFrame>& frame,
+ bool notify_client_of_new_frames);
scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner_;
+ scoped_ptr<base::TickClock> tick_clock_;
// These callbacks are executed on the compositor thread.
- base::Callback<void(gfx::Size)> natural_size_changed_cb_;
- base::Callback<void(bool)> opacity_changed_cb_;
+ const base::Callback<void(gfx::Size)> natural_size_changed_cb_;
+ const base::Callback<void(bool)> opacity_changed_cb_;
+
+ base::TimeDelta stale_frame_threshold_;
// These values are only set and read on the compositor thread.
cc::VideoFrameProvider::Client* client_;
scoped_refptr<VideoFrame> current_frame_;
+ bool rendering_;
+ bool rendered_last_frame_;
// These values are updated and read from the media and compositor threads.
base::Lock lock_;
- bool rendering_;
VideoRendererSink::RenderCallback* callback_;
+ // These values are set on the compositor thread under lock and may be read
+ // from the media thread under lock.
+ base::TimeTicks last_frame_update_time_;
+ base::TimeDelta last_interval_;
+
DISALLOW_COPY_AND_ASSIGN(VideoFrameCompositor);
};
« no previous file with comments | « media/base/video_renderer_sink.h ('k') | media/blink/video_frame_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698